Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IGNITE-24102 Remove VERSION_SINCE_CLIENT_COULD_WAIT_TO_CONNECT #11821

Merged
merged 1 commit into from
Feb 3, 2025
Merged

IGNITE-24102 Remove VERSION_SINCE_CLIENT_COULD_WAIT_TO_CONNECT #11821

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions .../main/java/org/apache/ignite/spi/communication/tcp/internal/InboundConnectionHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@
import org.apache.ignite.internal.util.typedef.internal.LT;
import org.apache.ignite.internal.util.typedef.internal.U;
import org.apache.ignite.lang.IgniteInClosure;
import org.apache.ignite.lang.IgniteProductVersion;
import org.apache.ignite.lang.IgniteRunnable;
import org.apache.ignite.plugin.extensions.communication.Message;
import org.apache.ignite.spi.communication.CommunicationListener;
Expand Down Expand Up @@ -76,12 +75,6 @@
* This class implement NioListener which process handshake stage, and transmit messages to session.
*/
public class InboundConnectionHandler extends GridNioServerListenerAdapter<Message> {
/**
* Version when client is ready to wait to connect to server (could be needed when client tries to open connection
* before it starts being visible for server)
*/
private static final IgniteProductVersion VERSION_SINCE_CLIENT_COULD_WAIT_TO_CONNECT = IgniteProductVersion.fromString("2.1.4");

/** Message tracker meta for session. */
private static final int TRACKER_META = GridNioSessionMetaKey.nextUniqueKey();

Expand Down Expand Up @@ -505,8 +498,7 @@ private void onFirstMessage(final GridNioSession ses, Message msg) {
if (node0 != null) {
assert node0.isClient() : node0;

if (node0.version().compareTo(VERSION_SINCE_CLIENT_COULD_WAIT_TO_CONNECT) >= 0)
unknownNode = false;
unknownNode = false;
}
}
else if (discoverySpi instanceof IgniteDiscoverySpi)
Expand Down