IGNITE-24053 Jdbc. Use single observable time tracker for multiple JDBC connections #5069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xtern
force-pushed
the
ignite-24053
branch
5 times, most recently
from
07a0f0c to
5b32958
Compare
xtern
changed the title
xtern
force-pushed
the
ignite-24053
branch
2 times, most recently
from
bb8a386 to
4af7a93
Compare
xtern
commented
Jan 21, 2025
| /** | ||
| * JDBC connection context. | ||
| */ | ||
| class JdbcConnectionContext { |
There was a problem hiding this comment.
this class is simply moved to the top level
xtern
commented
Jan 21, 2025
| /** {@link SqlQueryType}s allowed in JDBC select statements. **/ | ||
| public static final Set<SqlQueryType> SELECT_STATEMENT_QUERIES = Set.of( | ||
| SqlQueryType.QUERY, | ||
| SqlQueryType.EXPLAIN | ||
| ); | ||
|
|
||
| /** {@link SqlQueryType}s allowed in JDBC update statements. **/ | ||
| public static final Set<SqlQueryType> UPDATE_STATEMENT_QUERIES = Set.of(DML, DDL, KILL); |
xtern
changed the title
korlov42
reviewed
Jan 22, 2025
| * | ||
| * @return observable timestamp, or {@code null} if the observable time has not yet been initialized/updated. | ||
| */ | ||
| @Nullable HybridTimestamp observableTimestamp(); |
There was a problem hiding this comment.
I would suggest to save tracker in JdbcConnectionContext along with created transaction instead of adding a new method to InternalTransaction
| @@ -161,6 +162,9 @@ public class IgniteJdbcDriver implements Driver { | |||
| /** Minor version. */ | |||
| private static final int MINOR_VER = ProtocolVersion.LATEST_VER.minor(); | |||
|
|
|||
| /** Tracker of the latest time observed by client. */ | |||
| private final HybridTimestampTracker observableTimeTracker = HybridTimestampTracker.atomicTracker(null); | |||
There was a problem hiding this comment.
it would be nice to throw a few lines describing rationale behind having a single tracker per driver
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/IGNITE-24053
HybridTimestampTrackermoved tocoremodule so that it can be used by client.IgniteJdbcDriver. Single instance of tracker is used for all connections created using driver.observableTimefield.JdbcObservableTimeAwareRequestwith a time tracker was added.Time is transferred from client to server only when executing
queryAsync(..)method.Time is transferred from the server to the client when executing the following methods:
queryAsync(..)batchAsync(..)batchPrepStatementAsync(..)finishTxAsync(..)