IGNITE-24029 Sql schema. Extend Table API with supporting qualified names #5038
+677
−507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AMashenkov
force-pushed
the
ignite-24029
branch
13 times, most recently
from
8a5b0a5 to
12199b2
Compare
AMashenkov
force-pushed
the
ignite-24029
branch
4 times, most recently
from
89fd016 to
8bb2115
Compare
ptupitsyn
approved these changes
Jan 21, 2025
| @@ -72,6 +73,18 @@ static BroadcastJobTarget nodes(Set<ClusterNode> nodes) { | |||
| * @return Job target. | |||
| */ | |||
| static BroadcastJobTarget table(String tableName) { | |||
| return new TableJobTarget(tableName); | |||
| return table(QualifiedName.parse(tableName)); | |||
There was a problem hiding this comment.
should javadoc will be updated regarding what tableName is?
| * Creates a job target for partitioned execution. For each partition in the provided table the job will be executed on a node that | ||
| * holds the primary replica. | ||
| * | ||
| * @param tableName Table name. |
There was a problem hiding this comment.
the same, seems it should be mention not just a table name, but a fully qualified table name together with schema
| * @param tableName Table name. | ||
| */ | ||
| public TableNotFoundException(QualifiedName tableName) { | ||
| super(TABLE_NOT_FOUND_ERR, "The table does not exist [name=" + tableName.toCanonicalForm() + ']'); |
There was a problem hiding this comment.
can we use the new introduced method for the first constructor?
|
|
||
| /** | ||
| * Returns table descriptor by the given table ID and catalog version. |
There was a problem hiding this comment.
javadoc is not matched with method signature
| @@ -40,115 +40,115 @@ public partial class LinqSqlGenerationTests | |||
|
|
|||
| [Test] | |||
| public void TestSelectOneColumn() => | |||
| AssertSql("select _T0.KEY from PUBLIC.tbl1 as _T0", q => q.Select(x => x.Key).ToList()); | |||
| AssertSql("select _T0.KEY from PUBLIC.TBL1 as _T0", q => q.Select(x => x.Key).ToList()); | |||
There was a problem hiding this comment.
I don't understand why you changed tablename to uppercase everywhere - SQL is case-insensitive in these cases
AMashenkov
force-pushed
the
ignite-24029
branch
2 times, most recently
from
5c1be1e to
3de97f3
Compare
AMashenkov
force-pushed
the
ignite-24029
branch
from
3de97f3 to
406de82
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for submitting the pull request.
To streamline the review process of the patch and ensure better code quality
we ask both an author and a reviewer to verify the following:
The Review Checklist
- There is a single JIRA ticket related to the pull request.
- The web-link to the pull request is attached to the JIRA ticket.
- The JIRA ticket has the Patch Available state.
- The description of the JIRA ticket explains WHAT was made, WHY and HOW.
- The pull request title is treated as the final commit message. The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue.
Notes