Core,Format: Deprecate embedded manifests #11586
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core
Specification
Fokko
force-pushed
the
fd-deprecate-manifests
branch
2 times, most recently
from
77138b8
to
bfa9560
Compare
adutra
reviewed
Nov 19, 2024
nastra
reviewed
Nov 19, 2024
| /** | ||
| * Constructor with embedded manifests | ||
| * | ||
| * @deprecated since 1.8.0, will be removed 1.9.0 or 2.0.0 |
There was a problem hiding this comment.
Suggested change
| * @deprecated since 1.8.0, will be removed 1.9.0 or 2.0.0 | |
| * @deprecated since 1.8.0, will be removed in 1.9.0 |
nastra
reviewed
Nov 19, 2024
| @@ -81,6 +84,9 @@ static void toJson(Snapshot snapshot, JsonGenerator generator) throws IOExceptio | |||
| // write just the location. manifests should not be embedded in JSON along with a list | |||
| generator.writeStringField(MANIFEST_LIST, manifestList); | |||
| } else { | |||
| LOG.warn( | |||
| "Support for embedded manifests are deprecated since Java 1.8.0, will be removed in either 1.9.0 or 2.0.0"); | |||
There was a problem hiding this comment.
Suggested change
| "Support for embedded manifests are deprecated since Java 1.8.0, will be removed in either 1.9.0 or 2.0.0"); | |
| "Support for embedded manifests is deprecated since Iceberg 1.8.0 and will be removed in 2.0.0"); |
nastra
reviewed
Nov 19, 2024
| @@ -158,6 +164,9 @@ static Snapshot fromJson(JsonNode node) { | |||
| manifestList); | |||
|
|
|||
| } else { | |||
| LOG.warn( | |||
| "Support for embedded manifests are deprecated since Java 1.8.0, will be removed in either 1.9.0 or 2.0.0"); | |||
There was a problem hiding this comment.
Suggested change
| "Support for embedded manifests are deprecated since Java 1.8.0, will be removed in either 1.9.0 or 2.0.0"); | |
| "Support for embedded manifests is deprecated since Iceberg 1.8.0 and will be removed in 2.0.0"); |
nastra
reviewed
Nov 19, 2024
Fokko
force-pushed
the
fd-deprecate-manifests
branch
from
bfa9560
to
f4903e3
Compare
Fokko
force-pushed
the
fd-deprecate-manifests
branch
from
f4903e3
to
bc2f291
Compare
Comment on lines
+167
to
+168
| LOG.warn( | ||
| "Support for embedded manifests are deprecated since Iceberg 1.8.0, will be removed in either 1.9.0 or 2.0.0"); |
There was a problem hiding this comment.
Hm, I'm a bit concerned about deprecating the ability to read embedded manifests.
I certainly think it makes sense to stop writing them, but there may still be some v1 tables out there that we don't want to break reads on those in a later Iceberg version.
flyrain
reviewed
Nov 21, 2024
| @@ -81,6 +84,9 @@ static void toJson(Snapshot snapshot, JsonGenerator generator) throws IOExceptio | |||
| // write just the location. manifests should not be embedded in JSON along with a list | |||
| generator.writeStringField(MANIFEST_LIST, manifestList); | |||
| } else { | |||
| LOG.warn( | |||
| "Support for embedded manifests are deprecated since Iceberg 1.8.0, will be removed in either 1.9.0 or 2.0.0"); | |||
There was a problem hiding this comment.
Question: do we plan to go from 1.9.0 to 2.0.0, instead of 1.10.0?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The embedded manifests are not used outside of the company where Iceberg found its inception. I think it is a good thing to officially deprecate this field, and be able to remove the
DummyFileIOfrom the Java codebase at some point.