Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API, Core: Enable dropping rewritten delete files in RowDelta #11166

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

API, Core: Enable dropping rewritten delete files in RowDelta #11166

wants to merge 1 commit into from
+294 −0

Conversation

aokolnychyi
Copy link
Contributor

This PR enables query engines to drop rewritten historical deletes in RowDelta if they choose to support sync maintenance.

Benchmark                                             (numFiles)  Mode  Cnt  Score   Error  Units
ReplaceDeleteFilesBenchmark.replaceDeleteFiles             50000    ss    5  0.823 ± 1.783   s/op
ReplaceDeleteFilesBenchmark.replaceDeleteFiles            100000    ss    5  1.430 ± 0.081   s/op
ReplaceDeleteFilesBenchmark.replaceDeleteFiles            500000    ss    5  2.314 ± 0.396   s/op
ReplaceDeleteFilesBenchmark.replaceDeleteFiles           1000000    ss    5  2.557 ± 1.134   s/op
ReplaceDeleteFilesBenchmark.replaceDeleteFiles           2500000    ss    5  6.141 ± 1.685   s/op

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nastra nastra nastra approved these changes

@singhpk234 singhpk234 singhpk234 approved these changes

@amogh-jahagirdar amogh-jahagirdar amogh-jahagirdar approved these changes

Assignees
No one assigned
Labels
API core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aokolnychyi @nastra @singhpk234 @amogh-jahagirdar