Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for PostgreSQL #5

Merged
merged 5 commits into from
Aug 15, 2024
Merged

Conversation

Gerrrr
Copy link
Contributor

@Gerrrr Gerrrr commented Jul 29, 2022

Thank you for opensourcing hunter!

This PR adds support to using PostgreSQL as a data source for benchmark results. See the usage example below.

Configuration:

postgres:
  hostname: ${POSTGRES_HOST}
  port: ${POSTGRES_PORT}
  username: ${POSTGRES_USERNAME}
  password: ${POSTGRES_PASSWORD}
  database: ${POSTGRES_DATABASED}
templates:
  common:
    type: postgres
    time_column: ts
    attributes: [commit]
    metrics:
    ...

Test:

  # trunk
  trunk.aggregate_mem:
    inherit: [common]
    query: |
      SELECT e.*
      FROM experiments e
      INNER JOIN setups s ON e.setup_id = s.id
      WHERE e.exclude_from_analysis = false AND
            e.branch = 'trunk' AND
            s.benchmark = 'aggregate' AND
            s.scenario = 'singleNode' AND
            s.suppress = 'NONE' AND
            s.store = 'MEM' AND
            s.cache = true AND
            s.log = true AND
            s.sink = false AND
            s.keyspace = 10000 AND
            s.key_distribution = 'normal' AND
            s.partitions = 2 AND
            s.instance_type = 'ec2i3.large'
      ORDER BY e.ts ASC;

@Gerrrr Gerrrr force-pushed the postgres_importer branch 3 times, most recently from f4df9bc to bddb72b Compare August 31, 2022 13:06
@pkolaczk
Copy link
Contributor

pkolaczk commented Aug 8, 2023

Thank you for the contribution. Can you add more documentation on usage and about the expected database schema?

@Gerrrr Gerrrr force-pushed the postgres_importer branch from bddb72b to 8a03a93 Compare June 14, 2024 00:24
@Gerrrr
Copy link
Contributor Author

Gerrrr commented Jun 14, 2024

Hey @pkolaczk @smccarthy788 ,

I've updated this branch. It now includes requested documentation as well as PostgresExporter that completes psql support.

Can you please take another look at this PR?

@smccarthy788 smccarthy788 merged commit 7a8caec into apache:master Aug 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants