Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: improve error handling in storage module #34

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

xushiyan
Copy link
Member

@xushiyan xushiyan commented Jul 3, 2024

  • Change return values to Result<> for APIs in storage module for better error handling flows.
  • Concat RecordBatches into one for get_parquet_file_data()

@xushiyan xushiyan added this to the release-0.1.0 milestone Jul 3, 2024
Copy link

codecov bot commented Jul 3, 2024

Codecov Report

Attention: Patch coverage is 88.75000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 88.84%. Comparing base (199a25d) to head (a3a9b87).

Files Patch % Lines
crates/core/src/storage/mod.rs 87.14% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #34      +/-   ##
==========================================
- Coverage   90.63%   88.84%   -1.79%     
==========================================
  Files          10       10              
  Lines         491      511      +20     
==========================================
+ Hits          445      454       +9     
- Misses         46       57      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xushiyan xushiyan merged commit 52a9245 into apache:main Jul 3, 2024
5 of 7 checks passed
@xushiyan xushiyan deleted the improve-error-handling-storage branch July 3, 2024 03:18
@xushiyan xushiyan mentioned this pull request Jul 12, 2024
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant