Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: derive record merge strategy based on table configs #260

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

xushiyan
Copy link
Member

@xushiyan xushiyan commented Jan 23, 2025

Description

  • Derive hoodie.table.record.merge.strategy based on hoodie.populate.meta.fields and hoodie.table.precombine.field
  • Remove hard-coded default value
  • Add test cases for table with populate meta fields = false

How are the changes test-covered

  • N/A
  • Automated tests (unit and/or integration tests)
  • Manual tests
    • Details are described below

Sorry, something went wrong.

@xushiyan xushiyan added the bug Something isn't working label Jan 23, 2025
@xushiyan xushiyan added this to the release-0.3.0 milestone Jan 23, 2025
Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.20%. Comparing base (3527f54) to head (39d641b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #260      +/-   ##
==========================================
+ Coverage   91.13%   91.20%   +0.06%     
==========================================
  Files          40       40              
  Lines        1952     1967      +15     
==========================================
+ Hits         1779     1794      +15     
  Misses        173      173              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xushiyan xushiyan merged commit f722508 into apache:main Jan 23, 2025
13 checks passed
@xushiyan xushiyan deleted the derive-merge-strategy branch January 23, 2025 00:51
@xushiyan xushiyan mentioned this pull request Jan 30, 2025
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant