Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support incremental read MOR tables #258

Merged
merged 3 commits into from
Jan 22, 2025

Conversation

xushiyan
Copy link
Member

@xushiyan xushiyan commented Jan 21, 2025

Description

Adjust the arguments to pass time range to file group readers to support incremental read for MOR tables.

Closes #257

How are the changes test-covered

  • N/A
  • Automated tests (unit and/or integration tests)
  • Manual tests
    • Details are described below

@xushiyan xushiyan added feature rust Related to Rust codebase labels Jan 21, 2025
@xushiyan xushiyan added this to the release-0.3.0 milestone Jan 21, 2025
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 11 lines in your changes missing coverage. Please review.

Project coverage is 91.62%. Comparing base (493697b) to head (dbe632e).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/core/src/file_group/builder.rs 57.89% 8 Missing ⚠️
crates/core/src/table/mod.rs 50.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #258      +/-   ##
==========================================
- Coverage   92.05%   91.62%   -0.44%     
==========================================
  Files          40       40              
  Lines        1914     1935      +21     
==========================================
+ Hits         1762     1773      +11     
- Misses        152      162      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xushiyan xushiyan force-pushed the support-incr-api-mor branch from d26cebd to 5ef65f4 Compare January 22, 2025 02:15
@xushiyan xushiyan merged commit b658a98 into apache:main Jan 22, 2025
9 of 10 checks passed
@xushiyan xushiyan deleted the support-incr-api-mor branch January 22, 2025 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature rust Related to Rust codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support MOR incremental query
1 participant