Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support time travel query for MOR tables #256

Merged
merged 3 commits into from
Jan 22, 2025

Conversation

xushiyan
Copy link
Member

Description

  • Add InstantRange to support filter reading log blocks
  • Adjust file group reader APIs to accept InstantRange for filtering

Closes #255

How are the changes test-covered

  • N/A
  • Automated tests (unit and/or integration tests)
  • Manual tests
    • Details are described below

@xushiyan xushiyan added feature rust Related to Rust codebase labels Jan 21, 2025
@xushiyan xushiyan added this to the release-0.3.0 milestone Jan 21, 2025
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 90.80460% with 8 lines in your changes missing coverage. Please review.

Project coverage is 92.05%. Comparing base (ed267ee) to head (e1ca664).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/core/src/file_group/log_file/reader.rs 91.30% 2 Missing ⚠️
crates/core/src/file_group/reader.rs 66.66% 2 Missing ⚠️
crates/core/src/table/mod.rs 80.00% 2 Missing ⚠️
crates/tests/src/lib.rs 85.71% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #256      +/-   ##
==========================================
- Coverage   92.13%   92.05%   -0.08%     
==========================================
  Files          40       40              
  Lines        1844     1914      +70     
==========================================
+ Hits         1699     1762      +63     
- Misses        145      152       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xushiyan xushiyan merged commit 493697b into apache:main Jan 22, 2025
10 checks passed
@xushiyan xushiyan deleted the support-time-travel-mor branch January 22, 2025 02:07
@xushiyan xushiyan mentioned this pull request Jan 30, 2025
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature rust Related to Rust codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support MOR table time-travel queries
1 participant