Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: format Hudi config enum should show the full config key #254

Merged
merged 3 commits into from
Jan 22, 2025

Conversation

Kunal-Singh-Dadhwal
Copy link
Contributor

Description

  1. Implemented display trait for the HudiTableConfig
  2. Added Test

Closes #253

How are the changes test-covered

  • N/A
  • Automated tests (unit and/or integration tests)
  • Manual tests
    • Details are described below

@xushiyan xushiyan added this to the release-0.3.0 milestone Jan 22, 2025
@xushiyan xushiyan changed the title feat: Hudi Config Shows the full Config key fix: format Hudi config enum should show the full config key Jan 22, 2025
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

Attention: Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 91.13%. Comparing base (af997b7) to head (ebc9b84).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/core/src/config/internal.rs 0.00% 2 Missing ⚠️
crates/core/src/config/read.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #254      +/-   ##
==========================================
- Coverage   91.31%   91.13%   -0.18%     
==========================================
  Files          40       40              
  Lines        1946     1952       +6     
==========================================
+ Hits         1777     1779       +2     
- Misses        169      173       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xushiyan xushiyan added the bug Something isn't working label Jan 22, 2025
@xushiyan xushiyan merged commit 3527f54 into apache:main Jan 22, 2025
9 of 11 checks passed
@xushiyan
Copy link
Member

@Kunal-Singh-Dadhwal thanks for the PR!

@Kunal-Singh-Dadhwal Kunal-Singh-Dadhwal deleted the KunalSingh/#253 branch January 22, 2025 15:59
@xushiyan xushiyan mentioned this pull request Jan 30, 2025
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hudi Config formatted in string should show the full config key
2 participants