-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support filter pushdown for datafusion #203
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #203 +/- ##
==========================================
- Coverage 91.79% 91.34% -0.46%
==========================================
Files 21 24 +3
Lines 987 1074 +87
==========================================
+ Hits 906 981 +75
- Misses 81 93 +12 ☔ View full report in Codecov by Sentry. |
fixed conflicts |
@xushiyan Should we add some docs to see how to run codecov locally? It takes a lot of time out of the review process |
Yup having some command in |
I'm going to take a pass by today and fix wherever necessary, and then merge it. |
Description
Added
Expr
toPartitionFilter
conversion to pass in filters. Datafusion will pass down all filters for now usingsupports_filters_pushdown
and will filter after partition filters.Closes #160.
Steps forward
I noticed the pr was getting a bit big to be reviewed all at once, here are some things that will be worked on afterwards:
PartitionFilters
for testing, etc.How are the changes test-covered
Added unit tests for all added functionality