Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: define Hudi error types across hudi-core #124

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

gohalo
Copy link
Contributor

@gohalo gohalo commented Aug 31, 2024

Description

Use thiserror instead of anyhow to define the error for hudi-core crate.

Currently, work in progress.

#72

How are the changes test-covered

  • N/A
  • Automated tests (unit and/or integration tests)
  • Manual tests
    • Details are described below

@gohalo gohalo changed the title [wip] refact: define Hudi error types across hudi-core refact: define Hudi error types across hudi-core Sep 10, 2024
@gohalo
Copy link
Contributor Author

gohalo commented Sep 10, 2024

@xushiyan @codope
Hope this codes could be reviewed as soon as possible, because it refact the core crate, and almost every new merged code should refact again. 😊

Copy link

codecov bot commented Sep 11, 2024

Codecov Report

Attention: Patch coverage is 71.30435% with 33 lines in your changes missing coverage. Please review.

Project coverage is 86.80%. Comparing base (01ef2fc) to head (fb6ff8e).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
crates/core/src/table/mod.rs 33.33% 10 Missing ⚠️
crates/core/src/storage/utils.rs 56.25% 7 Missing ⚠️
crates/core/src/storage/mod.rs 78.94% 4 Missing ⚠️
python/src/internal.rs 0.00% 4 Missing ⚠️
crates/core/src/config/internal.rs 60.00% 2 Missing ⚠️
crates/core/src/config/table.rs 93.54% 2 Missing ⚠️
crates/core/src/file_group/mod.rs 71.42% 2 Missing ⚠️
crates/core/src/table/fs_view.rs 0.00% 1 Missing ⚠️
crates/core/src/table/timeline.rs 91.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #124      +/-   ##
==========================================
- Coverage   87.77%   86.80%   -0.98%     
==========================================
  Files          14       15       +1     
  Lines         728      773      +45     
==========================================
+ Hits          639      671      +32     
- Misses         89      102      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gohalo gohalo changed the title refact: define Hudi error types across hudi-core refactor: define Hudi error types across hudi-core Sep 11, 2024
@xushiyan xushiyan added refactor Code refactoring without any functionality or behavior change rust Related to Rust codebase labels Sep 15, 2024
@xushiyan xushiyan added this to the release-0.3.0 milestone Sep 15, 2024
@xushiyan xushiyan linked an issue Sep 15, 2024 that may be closed by this pull request
Signed-off-by: GoHalo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Code refactoring without any functionality or behavior change rust Related to Rust codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Define Hudi error types across hudi-core
2 participants