feat: add reserved column #1620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiacai2050
force-pushed
the
feat-reserved-columns
branch
from
e4e772c to
aaa5e4e
Compare
jiacai2050
force-pushed
the
feat-reserved-columns
branch
from
aaa5e4e to
9817e45
Compare
zealchen
reviewed
Dec 27, 2024
| pub fn fill_builtin_projections(&self, projection: &mut Option<Vec<usize>>) { | ||
| if let Some(proj) = projection.as_mut() { | ||
| for i in 0..self.num_primary_keys { | ||
| if !proj.contains(&i) { |
There was a problem hiding this comment.
primary keys are not builtin columns, why put them in here?
There was a problem hiding this comment.
Primary keys column are required when query, I will rename this function to fill_required_projections
jiacai2050
force-pushed
the
feat-reserved-columns
branch
from
7a9d163 to
cf2ff8a
Compare
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
In order to maintain compatibility, add a reserved column for future use.
Detailed Changes
Test Plan
CI