Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve] Improve the synchronization of the mute status. #2927

Merged
merged 5 commits into from
Jan 2, 2025

Conversation

yunfan24
Copy link
Contributor

@yunfan24 yunfan24 commented Dec 31, 2024

What's changed?

@zqr10159
hi
I apologize for the oversight in yesterday's PR Bug fix for alarm voice. It seems that the issue was not completely fixed because I forgot to convert the status of the data being sent to the backend. This PR is intended to address and fix that issue.

And Happy New Year!

Checklist

  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

Add or update API

  • I have added the necessary e2e tests and all cases have passed.

zqr10159
zqr10159 previously approved these changes Dec 31, 2024
Copy link
Member

@zqr10159 zqr10159 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zqr10159
Copy link
Member

please fix eslint problem

@yunfan24
Copy link
Contributor Author

please fix eslint problem

It should work now.

@zqr10159 zqr10159 merged commit ba21ef5 into apache:master Jan 2, 2025
3 checks passed
@yunfan24 yunfan24 deleted the improve-alarm-voice branch January 3, 2025 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants