Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve] Refactor and Split the Message Notification Component. #2924

Merged
merged 3 commits into from
Jan 3, 2025

Conversation

yunfan24
Copy link
Contributor

@yunfan24 yunfan24 commented Dec 31, 2024

What's changed?

The message notification component has been split into three parts to facilitate the addition of new features.@tomsun28


image

Checklist

  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

Add or update API

  • I have added the necessary e2e tests and all cases have passed.

Copy link
Contributor

@tomsun28 tomsun28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!👍

@tomsun28 tomsun28 merged commit dc96383 into apache:master Jan 3, 2025
3 checks passed
@yunfan24 yunfan24 deleted the split-component branch January 3, 2025 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

4 participants