HBASE-22335 do add hfile ref only when replication_scope is 1 #6955

chandrasekhar-188k · 2025-05-01T08:33:44Z

No description provided.

Apache9 · 2025-05-16T13:59:28Z

hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestBulkLoadReplication.java

+    // additional wait to make sure no extra bulk load happens
+    Thread.sleep(400);
+    assertEquals(1, BULK_LOADS_COUNT.get());
+    ZKWatcher zkw = UTIL1.getZooKeeperWatcher();


Please use ReplicationQueueStorage to get hfile refs, since on master we use a hbase table to track the replication queue, not zookeeper.

ok, i will update it.

PR is updated with the fix, pls review

Apache9 · 2025-06-01T14:18:40Z

Any updates here?

@chandrasekhar-188k

Apache9

Please open an PR against branch-2, since on branch-2 the method for getting replication queue storage is different I believe.

chandrasekhar-188k · 2025-06-19T13:37:28Z

Please open an PR against branch-2, since on branch-2 the method for getting replication queue storage is different I believe.

ok

chandrasekhar-188k · 2025-06-21T10:52:47Z

Please open an PR against branch-2, since on branch-2 the method for getting replication queue storage is different I believe.

#7115 for branch-2

Apache9 · 2025-06-29T13:19:03Z

@chandrasekhar-188k Please fix the checkstyle issue?

chandrasekhar-188k · 2025-06-30T14:46:19Z

@chandrasekhar-188k Please fix the checkstyle issue?

I have pushed the fixes for checkstyle issue and UT issue.

Apache-HBase · 2025-06-30T23:47:52Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 30s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ master Compile Tests _
+1 💚	mvninstall	4m 26s		master passed
+1 💚	compile	4m 36s		master passed
+1 💚	checkstyle	1m 0s		master passed
+1 💚	spotbugs	2m 17s		master passed
+1 💚	spotless	1m 3s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+1 💚	mvninstall	5m 6s		the patch passed
+1 💚	compile	3m 47s		the patch passed
+1 💚	javac	3m 47s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 40s		the patch passed
+1 💚	spotbugs	2m 10s		the patch passed
+1 💚	hadoopcheck	13m 8s		Patch does not cause any errors with Hadoop 3.3.6 3.4.0.
+1 💚	spotless	0m 56s		patch has no errors when running spotless:check.
			_ Other Tests _
+1 💚	asflicense	0m 12s		The patch does not generate ASF License warnings.
		48m 35s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6955/5/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#6955
Optional Tests	dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname	Linux 43b2ff714cdb 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `c0de21b`
Default Java	Eclipse Adoptium-17.0.11+9
Max. process+thread count	83 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6955/5/console
versions	git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2025-07-01T00:16:28Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 55s		Docker mode activated.
-0 ⚠️	yetus	0m 3s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ master Compile Tests _
+1 💚	mvninstall	4m 26s		master passed
+1 💚	compile	0m 57s		master passed
+1 💚	javadoc	0m 29s		master passed
+1 💚	shadedjars	7m 58s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	5m 11s		the patch passed
+1 💚	compile	1m 36s		the patch passed
+1 💚	javac	1m 36s		the patch passed
+1 💚	javadoc	0m 53s		the patch passed
+1 💚	shadedjars	9m 45s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
-1 ❌	unit	19m 33s	/patch-unit-hbase-server.txt	hbase-server in the patch failed.
		54m 2s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6955/5/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#6955
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux c2ba97d2d58b 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `c0de21b`
Default Java	Eclipse Adoptium-17.0.11+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6955/5/testReport/
Max. process+thread count	1852 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6955/5/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Co-authored-by: chenxu14 <[email protected]> Signed-off-by: Duo Zhang <[email protected]> (cherry picked from commit e3aacaf)

This comment has been minimized.

Sign in to view

Apache9 reviewed May 16, 2025

View reviewed changes

chandrasekhar-188k force-pushed the br_HBASE-22335 branch from 75292b5 to 8fcfef5 Compare June 18, 2025 14:58

chandrasekhar-188k requested a review from Apache9 June 18, 2025 14:58

Apache9 approved these changes Jun 18, 2025

View reviewed changes

This comment has been minimized.

Sign in to view

HBASE-22335 do add hfile ref only when replication_scope is 1

29bc490

chandrasekhar-188k force-pushed the br_HBASE-22335 branch from 8fcfef5 to 29bc490 Compare June 21, 2025 10:24

This comment has been minimized.

Sign in to view

Fix UT failures and check style issues

c0de21b

chandrasekhar-188k force-pushed the br_HBASE-22335 branch from 963aa9f to c0de21b Compare June 30, 2025 14:45

Apache9 approved these changes Jul 1, 2025

View reviewed changes

Apache9 merged commit e3aacaf into apache:master Jul 1, 2025
1 check failed

Apache9 pushed a commit that referenced this pull request Jul 1, 2025

HBASE-22335 do add hfile ref only when replication_scope is 1 (#6955)

4dfcd1b

Co-authored-by: chenxu14 <[email protected]> Signed-off-by: Duo Zhang <[email protected]> (cherry picked from commit e3aacaf)

HBASE-22335 do add hfile ref only when replication_scope is 1 #6955

HBASE-22335 do add hfile ref only when replication_scope is 1 #6955

Uh oh!

Conversation

chandrasekhar-188k commented May 1, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

Apache9 May 16, 2025

Choose a reason for hiding this comment

Uh oh!

chandrasekhar-188k Jun 18, 2025

Choose a reason for hiding this comment

Uh oh!

chandrasekhar-188k Jun 18, 2025

Choose a reason for hiding this comment

Uh oh!

Apache9 commented Jun 1, 2025

Uh oh!

Apache9 left a comment

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

This comment has been minimized.

chandrasekhar-188k commented Jun 19, 2025

Uh oh!

chandrasekhar-188k commented Jun 21, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

Apache9 commented Jun 29, 2025

Uh oh!

chandrasekhar-188k commented Jun 30, 2025

Uh oh!

Apache-HBase commented Jun 30, 2025

Uh oh!

Apache-HBase commented Jul 1, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants