HBASE-29267 Support shaded clients in Exception deserialization by prefixing shaded package in IPCUtil

[mwkang]

HBASE-29267

[Apache-HBase]

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 32s		Docker mode activated.
-0 ⚠️	yetus	0m 2s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ master Compile Tests _
+1 💚	mvninstall	3m 13s		master passed
+1 💚	compile	0m 20s		master passed
+1 💚	javadoc	0m 17s		master passed
+1 💚	shadedjars	5m 56s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	3m 4s		the patch passed
+1 💚	compile	0m 21s		the patch passed
+1 💚	javac	0m 21s		the patch passed
+1 💚	javadoc	0m 16s		the patch passed
+1 💚	shadedjars	5m 52s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 💚	unit	1m 35s		hbase-client in the patch passed.
		22m 38s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6917/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#6917
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux 097e06808130 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / ae20404
Default Java	Eclipse Adoptium-17.0.11+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6917/2/testReport/
Max. process+thread count	325 (vs. ulimit of 30000)
modules	C: hbase-client U: hbase-client
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6917/2/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

[Apache-HBase]

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	6m 27s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ master Compile Tests _
+1 💚	mvninstall	3m 30s		master passed
+1 💚	compile	0m 48s		master passed
+1 💚	checkstyle	0m 16s		master passed
+1 💚	spotbugs	0m 43s		master passed
+1 💚	spotless	0m 56s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+1 💚	mvninstall	6m 30s		the patch passed
+1 💚	compile	0m 49s		the patch passed
+1 💚	javac	0m 49s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-0 ⚠️	checkstyle	0m 15s	/results-checkstyle-hbase-client.txt	hbase-client: The patch generated 1 new + 1 unchanged - 0 fixed = 2 total (was 1)
+1 💚	spotbugs	0m 55s		the patch passed
+1 💚	hadoopcheck	21m 4s		Patch does not cause any errors with Hadoop 3.3.6 3.4.0.
+1 💚	spotless	0m 52s		patch has no errors when running spotless:check.
			_ Other Tests _
+1 💚	asflicense	0m 11s		The patch does not generate ASF License warnings.
		56m 54s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6917/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#6917
Optional Tests	dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname	Linux 28dfe1dab58b 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / ae20404
Default Java	Eclipse Adoptium-17.0.11+9
Max. process+thread count	83 (vs. ulimit of 30000)
modules	C: hbase-client U: hbase-client
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6917/2/console
versions	git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

[junegunn]

Thanks.

I've noticed that this patch can be incompatible with some shading configurations.

For example, here's one configuration we evaluated for using both HBase 1 and 2 clients in the same project:

tasks.shadowJar {
    relocate("org.apache.hadoop.hbase", "shaded.hbase1") {
        exclude("org/apache/hadoop/hbase/codec/**")

        // Exclude exceptions except protobuf and shaded packages
        exclude("%regex[org/apache/hadoop/hbase/((?!protobuf|shaded)[^/]+/.*)?[^/]+Exception]")
    }
    archiveClassifier.set("")
}

In this setup, we are replacing org.apache.hadoop.hbase with shaded.hbase1, rather than simply prepending a custom prefix, a strategy this patch currently assumes. As a result, we get:

ipc.ShadedPrefixUtil: Cannot find shaded pattern for shaded.hbase1.ipc

Also, note that we intentionally avoided shading *Exception classes to address the original issue of not recognizing exception names from the server. So modifying the class name would cause ClassNotFoundException.

[mwkang]

Thank you for your review.
Sorry for the late reply.
I will check the points you mentioned.