HADOOP-19371. JVM GC Metrics supports ZGC pause time and count #7230

cxzl25 · 2024-12-17T04:26:44Z

Description of PR

8265136: ZGC: Expose GarbageCollectorMXBeans for both pauses and cycles

https://bugs.openjdk.org/browse/JDK-8265136

How was this patch tested?

Local testing and production environment verification

For code changes:

Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

pan3793 · 2024-12-17T06:26:04Z

...common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/source/JvmMetrics.java

+      if (gcBean.getName() != null) {
+        String name = gcBean.getName();
+        // JDK-8265136 Skip concurrent phase
+        if ((name.startsWith("ZGC") && name.endsWith("Cycles"))) {


a redundant ()?

hadoop-yetus · 2024-12-17T07:56:25Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 55s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ trunk Compile Tests _
+1 💚	mvninstall	35m 31s		trunk passed
+1 💚	compile	16m 47s		trunk passed with JDK Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04
+1 💚	compile	15m 33s		trunk passed with JDK Private Build-1.8.0_432-8u432-ga~~us1-0ubuntu2~~20.04-ga
+1 💚	checkstyle	1m 20s		trunk passed
+1 💚	mvnsite	1m 36s		trunk passed
+1 💚	javadoc	1m 16s		trunk passed with JDK Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04
+1 💚	javadoc	0m 53s		trunk passed with JDK Private Build-1.8.0_432-8u432-ga~~us1-0ubuntu2~~20.04-ga
+1 💚	spotbugs	2m 38s		trunk passed
+1 💚	shadedclient	34m 55s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 53s		the patch passed
+1 💚	compile	16m 23s		the patch passed with JDK Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04
+1 💚	javac	16m 23s		the patch passed
+1 💚	compile	15m 22s		the patch passed with JDK Private Build-1.8.0_432-8u432-ga~~us1-0ubuntu2~~20.04-ga
+1 💚	javac	15m 22s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	1m 12s		the patch passed
+1 💚	mvnsite	1m 33s		the patch passed
+1 💚	javadoc	1m 9s		the patch passed with JDK Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04
+1 💚	javadoc	0m 53s		the patch passed with JDK Private Build-1.8.0_432-8u432-ga~~us1-0ubuntu2~~20.04-ga
+1 💚	spotbugs	2m 37s		the patch passed
+1 💚	shadedclient	35m 0s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	19m 58s		hadoop-common in the patch passed.
+1 💚	asflicense	1m 5s		The patch does not generate ASF License warnings.
		208m 21s

Subsystem	Report/Notes
Docker	ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7230/1/artifact/out/Dockerfile
GITHUB PR	#7230
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux 412d7db2c03d 5.15.0-124-generic #134-Ubuntu SMP Fri Sep 27 20:20:17 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `ed55dab`
Default Java	Private Build-1.8.0_432-8u432-ga~~us1-0ubuntu2~~20.04-ga
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_432-8u432-ga~~us1-0ubuntu2~~20.04-ga
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7230/1/testReport/
Max. process+thread count	1263 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7230/1/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

tomscut

LGTM.

pan3793 · 2024-12-19T02:37:13Z

cc @slfan1989

slfan1989 · 2024-12-20T00:40:07Z

cc @slfan1989

@pan3793 Thank you for inviting me to review the code! I have no issues with this PR, but this hardcoding approach doesn't seem ideal. Is there a better solution we could consider?
cc: @cxzl25 @tomscut

tomscut · 2024-12-20T01:59:40Z

cc @slfan1989

@pan3793 Thank you for inviting me to review the code! I have no issues with this PR, but this hardcoding approach doesn't seem ideal. Is there a better solution we could consider? cc: @cxzl25 @tomscut

Thanks for your comments. IMO, this is acceptable. The content related to JVM metric is rarely changed. We can also refer to micrometer.

slfan1989 · 2024-12-20T04:33:54Z

cc @slfan1989

@pan3793 Thank you for inviting me to review the code! I have no issues with this PR, but this hardcoding approach doesn't seem ideal. Is there a better solution we could consider? cc: @cxzl25 @tomscut

Thanks for your comments. IMO, this is acceptable. The content related to JVM metric is rarely changed. We can also refer to micrometer.

LGTM.

If there are no other issues, we will merge this PR in 2 days. Let's see if any team members have suggestions.

ZGC

ed55dab

github-actions bot added trunk Common labels Dec 17, 2024

pan3793 reviewed Dec 17, 2024

View reviewed changes

address

35ca5d7

tomscut approved these changes Dec 19, 2024

View reviewed changes

slfan1989 approved these changes Dec 20, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HADOOP-19371. JVM GC Metrics supports ZGC pause time and count #7230

HADOOP-19371. JVM GC Metrics supports ZGC pause time and count #7230

cxzl25 commented Dec 17, 2024

pan3793 Dec 17, 2024

hadoop-yetus commented Dec 17, 2024

tomscut left a comment

pan3793 commented Dec 19, 2024

slfan1989 commented Dec 20, 2024

tomscut commented Dec 20, 2024 •

edited

Loading

slfan1989 commented Dec 20, 2024 •

edited

Loading

HADOOP-19371. JVM GC Metrics supports ZGC pause time and count #7230

Are you sure you want to change the base?

HADOOP-19371. JVM GC Metrics supports ZGC pause time and count #7230

Conversation

cxzl25 commented Dec 17, 2024

Description of PR

How was this patch tested?

For code changes:

pan3793 Dec 17, 2024

Choose a reason for hiding this comment

hadoop-yetus commented Dec 17, 2024

tomscut left a comment

Choose a reason for hiding this comment

pan3793 commented Dec 19, 2024

slfan1989 commented Dec 20, 2024

tomscut commented Dec 20, 2024 • edited Loading

slfan1989 commented Dec 20, 2024 • edited Loading

tomscut commented Dec 20, 2024 •

edited

Loading

slfan1989 commented Dec 20, 2024 •

edited

Loading