YARN-11743. Cgroup v2 support should fall back to v1 when there are no v2 controllers #7222
+13
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
…o v2 controllers Change-Id: Ia6e80c5e4273af71c42e6e5efe64c7c91769a36e
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
brumi1024
reviewed
Dec 18, 2024
Comment on lines
81
to
83
| initializeCGroupV1Handler(conf); | ||
| if (cgroupsV2Enabled) { | ||
| if (cgroupsV2Enabled && !isMountedInCGroupsV1(controller)) { | ||
| initializeCGroupV2Handler(conf); |
There was a problem hiding this comment.
Just a thought: do we need to initialize the v1 handler if we're looking at clean v2 case?
There was a problem hiding this comment.
Thanks for the review @brumi1024! With the current logic we use the v1 handler to get the v1 controller paths and init v2 handler only if the given controller is not mounted in v1. But with a pure v2 setup I don't think we will use v1 handler after that check, there may be a cleaner way to determine this.
It's not the clean v2 setup, but with the resource plugins we still use only the v1 handler in this codepart, so probably additional checks would be needed there as well if we decide not to init the v1 handler.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id: Ia6e80c5e4273af71c42e6e5efe64c7c91769a36e
Description of PR
We should support a scenario where only cgroup v1 controllers are mounted, but cgroup v2 is enabled. Further details in the related ticket: https://issues.apache.org/jira/browse/YARN-11743
How was this patch tested?
Tested the following scenarios manually on a cluster with cgroup v2 enabled at YARN level:
The NMs could start up and jobs could run normally in every case, and the CPU and memory controller files have been updated with the limits.
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?