OutofBounds Exception due to assumption about buffer size in BlockCompressorStream #7167
+5
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
JIRA Issue: https://issues.apache.org/jira/browse/HADOOP-19339
BlockCompressorStream assumes that the buffer size will always be greater than the compression overhead, and consequently MAX_INPUT_SIZE will always be greater than or equal to 0.
How was this patch tested?
(1) Set io.compression.codec.snappy.buffersize to 7
(2) Run test: org.apache.hadoop.io.compress.TestCodec#testSnappyMapFile
Instead of an OOB exception, the code now throws an IllegalArgumentException with a relevant message.
For code changes:
LICENSE
,LICENSE-binary
,NOTICE-binary
files?