Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HADOOP-19329. Remove usage of sun.misc.Signal #7145

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from

Conversation

myandpr
Copy link
Contributor

@myandpr myandpr commented Nov 5, 2024

Description of PR

JIRA: HADOOP-19329. Remove usage of sun.misc.Signal

Fix compilation errors during the upgrade process, because sun.misc is not supported after jdk11.

we replace sun.misc.Signal and sum.misc.SignalHandler using jnr-posix

How was this patch tested?

exist ut test

For code changes:

replace sun.misc.Signal and sum.misc.SignalHandler using jnr.constants.platform.Signal and jnr.posix.SignalHandler in jnr-posix

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 48s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+0 🆗 xmllint 0m 0s xmllint was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
+1 💚 mvninstall 50m 49s trunk passed
+1 💚 compile 20m 20s trunk passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚 compile 19m 33s trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 💚 checkstyle 1m 20s trunk passed
+1 💚 mvnsite 1m 48s trunk passed
+1 💚 javadoc 1m 15s trunk passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚 javadoc 0m 49s trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 💚 spotbugs 2m 39s trunk passed
+1 💚 shadedclient 43m 59s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 1m 13s the patch passed
+1 💚 compile 20m 4s the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚 javac 20m 4s root-jdkUbuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04 with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04 generated 0 new + 20 unchanged - 15 fixed = 20 total (was 35)
+1 💚 compile 19m 25s the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 💚 javac 19m 25s root-jdkPrivateBuild-1.8.0_422-8u422-b05-120.04-b05 with JDK Private Build-1.8.0_422-8u422-b05-120.04-b05 generated 0 new + 29 unchanged - 15 fixed = 29 total (was 44)
+1 💚 blanks 0m 0s The patch has no blanks issues.
-0 ⚠️ checkstyle 1m 16s /results-checkstyle-hadoop-common-project_hadoop-common.txt hadoop-common-project/hadoop-common: The patch generated 2 new + 1 unchanged - 7 fixed = 3 total (was 8)
+1 💚 mvnsite 1m 45s the patch passed
-1 ❌ javadoc 1m 12s /patch-javadoc-hadoop-common-project_hadoop-common-jdkUbuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04.txt hadoop-common in the patch failed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04.
+1 💚 javadoc 0m 51s the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 💚 spotbugs 3m 2s the patch passed
-1 ❌ shadedclient 13m 33s patch has errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 20m 45s hadoop-common in the patch passed.
+1 💚 asflicense 0m 59s The patch does not generate ASF License warnings.
227m 58s
Subsystem Report/Notes
Docker ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7145/1/artifact/out/Dockerfile
GITHUB PR #7145
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint spotbugs checkstyle
uname Linux 561b7fb31f73 5.15.0-124-generic #134-Ubuntu SMP Fri Sep 27 20:20:17 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 197dbf1
Default Java Private Build-1.8.0_422-8u422-b05-1~20.04-b05
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_422-8u422-b05-1~20.04-b05
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7145/1/testReport/
Max. process+thread count 1449 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7145/1/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 54s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 1s codespell was not available.
+0 🆗 detsecrets 0m 1s detect-secrets was not available.
+0 🆗 xmllint 0m 1s xmllint was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
+1 💚 mvninstall 52m 10s trunk passed
+1 💚 compile 25m 46s trunk passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚 compile 20m 45s trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 💚 checkstyle 1m 26s trunk passed
+1 💚 mvnsite 1m 58s trunk passed
+1 💚 javadoc 1m 30s trunk passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚 javadoc 0m 58s trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 💚 spotbugs 3m 2s trunk passed
+1 💚 shadedclient 44m 15s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 1m 16s the patch passed
+1 💚 compile 22m 37s the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚 javac 22m 37s root-jdkUbuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04 with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04 generated 0 new + 20 unchanged - 15 fixed = 20 total (was 35)
+1 💚 compile 20m 0s the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 💚 javac 20m 0s root-jdkPrivateBuild-1.8.0_422-8u422-b05-120.04-b05 with JDK Private Build-1.8.0_422-8u422-b05-120.04-b05 generated 0 new + 29 unchanged - 15 fixed = 29 total (was 44)
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 1m 16s hadoop-common-project/hadoop-common: The patch generated 0 new + 1 unchanged - 7 fixed = 1 total (was 8)
+1 💚 mvnsite 1m 55s the patch passed
+1 💚 javadoc 1m 23s the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚 javadoc 0m 58s the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 💚 spotbugs 3m 0s the patch passed
-1 ❌ shadedclient 14m 26s patch has errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 20m 54s hadoop-common in the patch passed.
+1 💚 asflicense 1m 7s The patch does not generate ASF License warnings.
242m 2s
Subsystem Report/Notes
Docker ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7145/2/artifact/out/Dockerfile
GITHUB PR #7145
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint spotbugs checkstyle
uname Linux 662853e191a5 5.15.0-124-generic #134-Ubuntu SMP Fri Sep 27 20:20:17 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 2a89df4
Default Java Private Build-1.8.0_422-8u422-b05-1~20.04-b05
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_422-8u422-b05-1~20.04-b05
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7145/2/testReport/
Max. process+thread count 3016 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7145/2/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

Copy link
Contributor

@jojochuang jojochuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you like to open a new jira? HADOOP-19318 is resolved as workaround.

@@ -416,6 +416,12 @@
<artifactId>lz4-java</artifactId>
<scope>provided</scope>
</dependency>
<dependency>
<groupId>com.github.jnr</groupId>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the license is tri EPL/GPL/LGPL license. Should be fine.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your review, and i have added com.github.jnr to GPLv2 module in LICENSE-binary file.

@jojochuang
Copy link
Contributor

jojochuang commented Nov 6, 2024

shadedclient is broken. That needs to be fixed.

I am getting this error compiling with JDK8:

[ERROR] Rule 0: org.apache.maven.enforcer.rules.dependency.DependencyConvergence failed with message:
[ERROR] Failed while enforcing releasability.
[ERROR]
[ERROR] Dependency convergence error for org.ow2.asm:asm-commons:jar:9.7.1 paths to dependency are:
[ERROR] +-org.apache.hadoop:hadoop-yarn-server-nodemanager:jar:3.5.0-SNAPSHOT
[ERROR] +-org.apache.hadoop:hadoop-registry:jar:3.5.0-SNAPSHOT:compile
[ERROR] +-org.apache.hadoop:hadoop-common:jar:3.5.0-SNAPSHOT:compile
[ERROR] +-com.github.jnr:jnr-posix:jar:3.1.20:compile
[ERROR] +-com.github.jnr:jnr-ffi:jar:2.2.17:compile
[ERROR] +-org.ow2.asm:asm-commons:jar:9.7.1:compile
[ERROR] and
[ERROR] +-org.apache.hadoop:hadoop-yarn-server-nodemanager:jar:3.5.0-SNAPSHOT
[ERROR] +-org.eclipse.jetty.websocket:javax-websocket-server-impl:jar:9.4.53.v20231009:compile
[ERROR] +-org.eclipse.jetty:jetty-annotations:jar:9.4.53.v20231009:compile
[ERROR] +-org.ow2.asm:asm-commons:jar:9.6:compile

@myandpr
Copy link
Contributor Author

myandpr commented Nov 6, 2024

Would you like to open a new jira? HADOOP-19318 is resolved as workaround.

OK. My Jira account will be granted permissions soon, and I’ll create a new Jira right after that.

@myandpr
Copy link
Contributor Author

myandpr commented Nov 6, 2024

shadedclient is broken. That needs to be fixed.

I am getting this error compiling with JDK8:

[ERROR] Rule 0: org.apache.maven.enforcer.rules.dependency.DependencyConvergence failed with message: [ERROR] Failed while enforcing releasability. [ERROR] [ERROR] Dependency convergence error for org.ow2.asm:asm-commons:jar:9.7.1 paths to dependency are: [ERROR] +-org.apache.hadoop:hadoop-yarn-server-nodemanager:jar:3.5.0-SNAPSHOT [ERROR] +-org.apache.hadoop:hadoop-registry:jar:3.5.0-SNAPSHOT:compile [ERROR] +-org.apache.hadoop:hadoop-common:jar:3.5.0-SNAPSHOT:compile [ERROR] +-com.github.jnr:jnr-posix:jar:3.1.20:compile [ERROR] +-com.github.jnr:jnr-ffi:jar:2.2.17:compile [ERROR] +-org.ow2.asm:asm-commons:jar:9.7.1:compile [ERROR] and [ERROR] +-org.apache.hadoop:hadoop-yarn-server-nodemanager:jar:3.5.0-SNAPSHOT [ERROR] +-org.eclipse.jetty.websocket:javax-websocket-server-impl:jar:9.4.53.v20231009:compile [ERROR] +-org.eclipse.jetty:jetty-annotations:jar:9.4.53.v20231009:compile [ERROR] +-org.ow2.asm:asm-commons:jar:9.6:compile

I have excluded the conflicting dependencies related to the jnr-posix module,could you please help review this change again?Many thanks.

@myandpr
Copy link
Contributor Author

myandpr commented Nov 6, 2024

@slfan1989 Could you please help review this PR? Thank you very much.

@myandpr myandpr closed this Nov 6, 2024
@myandpr myandpr reopened this Nov 6, 2024
LICENSE-binary Outdated
@@ -498,6 +498,7 @@ org.slf4j:slf4j-reload4j:1.7.36
CDDL 1.1 + GPLv2 with classpath exception
-----------------------------------------

com.github.jnr:jnr-posix:3.1.19
Copy link
Contributor

@jojochuang jojochuang Nov 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually it's not CDDL 1.1 + GPLv2 with classpath exception. Eclipse Public License 1/.02.0 is acceptable though. I think let's add a new section for "Eclipse Public License 2.0" under "Eclipse Public License 1.0"

For more details, check out Apache's thirdparty license policy: https://www.apache.org/legal/resolved.html

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.You are right, I added EPL 2.0 section.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 33s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+0 🆗 xmllint 0m 0s xmllint was not available.
+0 🆗 shelldocs 0m 0s Shelldocs was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
+0 🆗 mvndep 15m 47s Maven dependency ordering for branch
+1 💚 mvninstall 32m 29s trunk passed
+1 💚 compile 17m 29s trunk passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚 compile 18m 44s trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 💚 checkstyle 4m 35s trunk passed
+1 💚 mvnsite 25m 6s trunk passed
+1 💚 javadoc 9m 52s trunk passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚 javadoc 8m 6s trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+0 🆗 spotbugs 0m 21s branch/hadoop-project no spotbugs output file (spotbugsXml.xml)
+0 🆗 spotbugs 0m 22s branch/hadoop-client-modules/hadoop-client-runtime no spotbugs output file (spotbugsXml.xml)
+0 🆗 spotbugs 0m 22s branch/hadoop-client-modules/hadoop-client-minicluster no spotbugs output file (spotbugsXml.xml)
+1 💚 shadedclient 67m 25s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 46s Maven dependency ordering for patch
+1 💚 mvninstall 50m 6s the patch passed
+1 💚 compile 17m 1s the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚 javac 17m 1s root-jdkUbuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04 with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04 generated 0 new + 20 unchanged - 15 fixed = 20 total (was 35)
+1 💚 compile 16m 6s the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 💚 javac 16m 6s root-jdkPrivateBuild-1.8.0_422-8u422-b05-120.04-b05 with JDK Private Build-1.8.0_422-8u422-b05-120.04-b05 generated 0 new + 29 unchanged - 15 fixed = 29 total (was 44)
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 4m 20s root: The patch generated 0 new + 1 unchanged - 7 fixed = 1 total (was 8)
+1 💚 mvnsite 19m 42s the patch passed
+1 💚 shellcheck 0m 0s No new issues.
+1 💚 javadoc 9m 47s the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚 javadoc 8m 6s the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+0 🆗 spotbugs 0m 21s hadoop-project has no data from spotbugs
+0 🆗 spotbugs 0m 22s hadoop-client-modules/hadoop-client-runtime has no data from spotbugs
+0 🆗 spotbugs 0m 22s hadoop-client-modules/hadoop-client-minicluster has no data from spotbugs
+1 💚 shadedclient 66m 11s patch has no errors when building and testing our client artifacts.
_ Other Tests _
-1 ❌ unit 781m 25s /patch-unit-root.txt root in the patch passed.
+1 💚 asflicense 1m 41s The patch does not generate ASF License warnings.
1190m 47s
Reason Tests
Failed junit tests hadoop.hdfs.TestDecommissionWithBackoffMonitor
hadoop.hdfs.TestDecommission
Subsystem Report/Notes
Docker ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7145/3/artifact/out/Dockerfile
GITHUB PR #7145
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint spotbugs checkstyle shellcheck shelldocs
uname Linux 580049f13ee2 5.15.0-124-generic #134-Ubuntu SMP Fri Sep 27 20:20:17 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 3c96495
Default Java Private Build-1.8.0_422-8u422-b05-1~20.04-b05
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_422-8u422-b05-1~20.04-b05
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7145/3/testReport/
Max. process+thread count 4710 (vs. ulimit of 5500)
modules C: hadoop-project hadoop-common-project/hadoop-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-client-modules/hadoop-client-runtime hadoop-client-modules/hadoop-client-minicluster . U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7145/3/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2 shellcheck=0.7.0
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@myandpr myandpr changed the title HADOOP-19318. Remove usage of sun.misc.Signal HADOOP-19329. Remove usage of sun.misc.Signal Nov 7, 2024
@myandpr
Copy link
Contributor Author

myandpr commented Nov 7, 2024

Would you like to open a new jira? HADOOP-19318 is resolved as workaround.

Opened a new JIRA HADOOP-19329.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 47s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 1s codespell was not available.
+0 🆗 detsecrets 0m 1s detect-secrets was not available.
+0 🆗 xmllint 0m 1s xmllint was not available.
+0 🆗 shelldocs 0m 1s Shelldocs was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
+0 🆗 mvndep 15m 41s Maven dependency ordering for branch
+1 💚 mvninstall 37m 13s trunk passed
+1 💚 compile 19m 57s trunk passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚 compile 21m 26s trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 💚 checkstyle 5m 52s trunk passed
+1 💚 mvnsite 27m 13s trunk passed
+1 💚 javadoc 12m 1s trunk passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚 javadoc 8m 22s trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+0 🆗 spotbugs 0m 19s branch/hadoop-project no spotbugs output file (spotbugsXml.xml)
+0 🆗 spotbugs 0m 21s branch/hadoop-client-modules/hadoop-client-runtime no spotbugs output file (spotbugsXml.xml)
+0 🆗 spotbugs 0m 20s branch/hadoop-client-modules/hadoop-client-minicluster no spotbugs output file (spotbugsXml.xml)
+1 💚 shadedclient 78m 32s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 43s Maven dependency ordering for patch
+1 💚 mvninstall 58m 53s the patch passed
+1 💚 compile 19m 41s the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚 javac 19m 41s root-jdkUbuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04 with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04 generated 0 new + 20 unchanged - 15 fixed = 20 total (was 35)
+1 💚 compile 20m 4s the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 💚 javac 20m 4s root-jdkPrivateBuild-1.8.0_422-8u422-b05-120.04-b05 with JDK Private Build-1.8.0_422-8u422-b05-120.04-b05 generated 0 new + 29 unchanged - 15 fixed = 29 total (was 44)
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 5m 50s root: The patch generated 0 new + 1 unchanged - 7 fixed = 1 total (was 8)
+1 💚 mvnsite 21m 8s the patch passed
+1 💚 shellcheck 0m 0s No new issues.
+1 💚 javadoc 12m 7s the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚 javadoc 8m 42s the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+0 🆗 spotbugs 0m 18s hadoop-project has no data from spotbugs
+0 🆗 spotbugs 0m 24s hadoop-client-modules/hadoop-client-runtime has no data from spotbugs
+0 🆗 spotbugs 0m 22s hadoop-client-modules/hadoop-client-minicluster has no data from spotbugs
+1 💚 shadedclient 78m 38s patch has no errors when building and testing our client artifacts.
_ Other Tests _
-1 ❌ unit 762m 22s /patch-unit-root.txt root in the patch failed.
+1 💚 asflicense 1m 23s The patch does not generate ASF License warnings.
1233m 35s
Reason Tests
Unreaped Processes root:2
Failed junit tests hadoop.hdfs.server.federation.router.TestRouterRpcMultiDestination
Subsystem Report/Notes
Docker ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7145/4/artifact/out/Dockerfile
GITHUB PR #7145
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint spotbugs checkstyle shellcheck shelldocs
uname Linux 8bca32e8ad67 5.15.0-124-generic #134-Ubuntu SMP Fri Sep 27 20:20:17 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 778c237
Default Java Private Build-1.8.0_422-8u422-b05-1~20.04-b05
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_422-8u422-b05-1~20.04-b05
Unreaped Processes Log https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7145/4/artifact/out/patch-unit-root-reaper.txt
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7145/4/testReport/
Max. process+thread count 3538 (vs. ulimit of 5500)
modules C: hadoop-project hadoop-common-project/hadoop-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-client-modules/hadoop-client-runtime hadoop-client-modules/hadoop-client-minicluster . U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7145/4/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2 shellcheck=0.7.0
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 51s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+0 🆗 xmllint 0m 0s xmllint was not available.
+0 🆗 shelldocs 0m 0s Shelldocs was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
+0 🆗 mvndep 14m 38s Maven dependency ordering for branch
+1 💚 mvninstall 38m 33s trunk passed
+1 💚 compile 21m 50s trunk passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚 compile 18m 15s trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 💚 checkstyle 5m 22s trunk passed
+1 💚 mvnsite 28m 11s trunk passed
+1 💚 javadoc 12m 7s trunk passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚 javadoc 8m 42s trunk passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+0 🆗 spotbugs 0m 20s branch/hadoop-project no spotbugs output file (spotbugsXml.xml)
+0 🆗 spotbugs 0m 19s branch/hadoop-client-modules/hadoop-client-runtime no spotbugs output file (spotbugsXml.xml)
+0 🆗 spotbugs 0m 21s branch/hadoop-client-modules/hadoop-client-minicluster no spotbugs output file (spotbugsXml.xml)
+1 💚 shadedclient 75m 34s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 43s Maven dependency ordering for patch
+1 💚 mvninstall 59m 51s the patch passed
+1 💚 compile 21m 24s the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚 javac 21m 24s root-jdkUbuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04 with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04 generated 0 new + 20 unchanged - 15 fixed = 20 total (was 35)
+1 💚 compile 19m 51s the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+1 💚 javac 19m 51s root-jdkPrivateBuild-1.8.0_422-8u422-b05-120.04-b05 with JDK Private Build-1.8.0_422-8u422-b05-120.04-b05 generated 0 new + 29 unchanged - 15 fixed = 29 total (was 44)
+1 💚 blanks 0m 1s The patch has no blanks issues.
+1 💚 checkstyle 5m 25s root: The patch generated 0 new + 1 unchanged - 7 fixed = 1 total (was 8)
+1 💚 mvnsite 20m 29s the patch passed
+1 💚 shellcheck 0m 0s No new issues.
+1 💚 javadoc 12m 7s the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04
+1 💚 javadoc 8m 42s the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~20.04-b05
+0 🆗 spotbugs 0m 20s hadoop-project has no data from spotbugs
+0 🆗 spotbugs 0m 22s hadoop-client-modules/hadoop-client-runtime has no data from spotbugs
+0 🆗 spotbugs 0m 20s hadoop-client-modules/hadoop-client-minicluster has no data from spotbugs
+1 💚 shadedclient 77m 25s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 878m 53s root in the patch passed.
+1 💚 asflicense 1m 40s The patch does not generate ASF License warnings.
1347m 25s
Subsystem Report/Notes
Docker ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7145/5/artifact/out/Dockerfile
GITHUB PR #7145
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint spotbugs checkstyle shellcheck shelldocs
uname Linux 97e18e8fbe26 5.15.0-124-generic #134-Ubuntu SMP Fri Sep 27 20:20:17 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 778c237
Default Java Private Build-1.8.0_422-8u422-b05-1~20.04-b05
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu320.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_422-8u422-b05-1~20.04-b05
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7145/5/testReport/
Max. process+thread count 3505 (vs. ulimit of 5500)
modules C: hadoop-project hadoop-common-project/hadoop-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-client-modules/hadoop-client-runtime hadoop-client-modules/hadoop-client-minicluster . U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7145/5/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2 shellcheck=0.7.0
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

Eclipse Public License 2.0
--------------------------

com.github.jnr:jnr-posix:3.1.19
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it also pulls transitive jars.

Honestly, it's a bit heavy to pull bunches of jars to just work around the access of sun.misc.Signal API. Could it be addressed by using reflection?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pan3793 This change is likely based on related modifications in Ozone. If reflection is used, could you provide some specific implementation ideas?

Ozone:
JIRA: HDDS-11078. Remove usage of sun.misc.Signal
apache/ozone#7006
apache/ozone#6876

@myandpr Is there any additional information?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exactly, and the problem is that sun.misc package is no longer supported after JDK 9,even removed in a future release( related information: https://openjdk.org/jeps/260). @slfan1989 @pan3793

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants