Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#6349] fix(core,hive-catalog): Fix bugs in AuthorizationUtils and remove protobuf-java from catalog hive #6351

Merged
merged 3 commits into from
Jan 22, 2025

Conversation

yuqi1129
Copy link
Contributor

@yuqi1129 yuqi1129 commented Jan 22, 2025

What changes were proposed in this pull request?

  • Fix some working not null judge logic in AuthorizationUtils
  • Remove protobuf-java jar from hive distribution package

Why are the changes needed?

It's bug that need to fix

Fix: #6349

Does this PR introduce any user-facing change?

N/A

How was this patch tested?

UT.

@yuqi1129 yuqi1129 requested a review from xunliu January 22, 2025 09:09
@yuqi1129 yuqi1129 self-assigned this Jan 22, 2025
@yuqi1129 yuqi1129 added the branch-0.8 Automatically cherry-pick commit to branch-0.8 label Jan 22, 2025
@jerqi
Copy link
Contributor

jerqi commented Jan 22, 2025

Could you add a UT for this?

Copy link
Contributor

@jerqi jerqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Merged to branch main & 0.8.

@jerqi jerqi merged commit 97b61ca into apache:main Jan 22, 2025
28 checks passed
github-actions bot pushed a commit that referenced this pull request Jan 22, 2025
…move protobuf-java from catalog hive (#6351)

### What changes were proposed in this pull request?

- Fix some working not null judge logic in AuthorizationUtils
- Remove `protobuf-java` jar from hive distribution package

### Why are the changes needed?

It's bug that need to fix

Fix: #6349

### Does this PR introduce _any_ user-facing change?

N/A

### How was this patch tested?

UT.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch-0.8 Automatically cherry-pick commit to branch-0.8
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug report] Wrong empty judge logic in AuthorizationUtils
2 participants