feat(spark-connector):support JDBC catalog #6212
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your PR, could you add corresponding IT? You could refer to |
add integeration test
liangyouze
force-pushed
the
spark-jdbc
branch
from
8b20d04 to
72e0ead
Compare
|
The code looks clean; looking forward to have it. |
FANNG1
reviewed
Jan 21, 2025
FANNG1
reviewed
Jan 21, 2025
| @@ -39,6 +39,9 @@ val scalaCollectionCompatVersion: String = libs.versions.scala.collection.compat | |||
|
|
|||
| dependencies { | |||
| implementation(project(":catalogs:catalog-common")) | |||
| implementation(project(":catalogs:catalog-jdbc-common")) { | |||
There was a problem hiding this comment.
catalogs:catalog-jdbc-common is the module of Gravitino server, why adding this dependences?
There was a problem hiding this comment.
remove this will cause integration tests to fail. https://github.com/apache/gravitino/actions/runs/12900772663/job/35971803812?pr=6212
There was a problem hiding this comment.
we need to fix the IT failures, we could checkout the errors in server side. you could download the log in https://github.com/apache/gravitino/actions/runs/12900772663?pr=6212
FANNG1
reviewed
Jan 21, 2025
...k-common/src/main/java/org/apache/gravitino/spark/connector/jdbc/SparkJdbcTypeConverter.java
Show resolved
Hide resolved
FANNG1
reviewed
Jan 21, 2025
...ommon/src/test/java/org/apache/gravitino/spark/connector/integration/test/SparkCommonIT.java
Outdated
Show resolved
Hide resolved
FANNG1
reviewed
Jan 21, 2025
...test/java/org/apache/gravitino/spark/connector/integration/test/jdbc/SparkJdbcCatalogIT.java
Outdated
Show resolved
Hide resolved
FANNG1
reviewed
Jan 21, 2025
...va/org/apache/gravitino/spark/connector/integration/test/jdbc/SparkJdbcTableInfoChecker.java
Show resolved
Hide resolved
FANNG1
reviewed
Jan 21, 2025
FANNG1
reviewed
Jan 21, 2025
liangyouze
force-pushed
the
spark-jdbc
branch
from
66a0162 to
dfff9aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Support JDBC catalog in Spark Connector
Why are the changes needed?
Fix: #1572 #6164
Does this PR introduce any user-facing change?
no
How was this patch tested?
TestJdbcPropertiesConverter
SparkJdbcCatalogIT