-
-
Notifications
You must be signed in to change notification settings - Fork 971
Update to Groovy 4.0.30 & support changing to a staged version of Groovy #15320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 7.0.x
Are you sure you want to change the base?
Conversation
|
More work will need to be done to allow groovy staging builds to be included - the generated applications can't find the staging repo since it's not set. |
…tory settings plugin
|
finally decided to just create a repo settings plugin in build-logic; this allows us to centrally define the repositories for all of grails projects in core in For the forge tests, I'm not sure what to do. We already define an override for GRAILS_REPO_URL so the tests pickup the local grails-core code. We need to leave that, but somehow we need to either add the staging repo or our repo settings plugin. I'm not sure if we should publish our repo settings plugin since that could lead to a burden on repository.apache.org @matrei do you have any ideas here? For now, I think when groovy 4.0.30 releases we should merge this PR either way. We can address the forge issue longer term. |
|
We could also just support multiple repos in GRAILS_REPO_URL by using a separator ... |
|
@jdaugherty For Staged Groovy version support in the forge generated applications, I think we should make the same repositories changes in: This will only impact Grails snapshots. |
So duplicate the change instead of importing the plugin? |
|
I see that plugin now, if it can be used in the grails-forge generated application, then let's use it. |
I think these are the required changes to support a staged version of groovy. This PR also switches us to 4.0.30 - we shouldn't merge it until Groovy is released, but this is a good time to test staged releases used in dev.