Skip to content

Conversation

@jdaugherty
Copy link
Contributor

I think these are the required changes to support a staged version of groovy. This PR also switches us to 4.0.30 - we shouldn't merge it until Groovy is released, but this is a good time to test staged releases used in dev.

@jdaugherty
Copy link
Contributor Author

More work will need to be done to allow groovy staging builds to be included - the generated applications can't find the staging repo since it's not set.

@jdaugherty
Copy link
Contributor Author

finally decided to just create a repo settings plugin in build-logic; this allows us to centrally define the repositories for all of grails projects in core in build-logic/plugins/src/main/groovy/org/apache/grails/buildsrc/GrailsRepoSettingsPlugin.groovy @jamesfredley I think we've discussed this before and hopefully this makes it easier to maintain.

For the forge tests, I'm not sure what to do. We already define an override for GRAILS_REPO_URL so the tests pickup the local grails-core code. We need to leave that, but somehow we need to either add the staging repo or our repo settings plugin. I'm not sure if we should publish our repo settings plugin since that could lead to a burden on repository.apache.org @matrei do you have any ideas here?

For now, I think when groovy 4.0.30 releases we should merge this PR either way. We can address the forge issue longer term.

@jdaugherty
Copy link
Contributor Author

We could also just support multiple repos in GRAILS_REPO_URL by using a separator ...

@jamesfredley
Copy link
Contributor

@jdaugherty For Staged Groovy version support in the forge generated applications, I think we should make the same repositories changes in:

https://github.com/apache/grails-core/blob/7.0.x/grails-forge/grails-forge-core/src/main/java/org/grails/forge/build/gradle/GradleRepository.java#L41-L62

This will only impact Grails snapshots.

@jdaugherty
Copy link
Contributor Author

@jdaugherty For Staged Groovy version support in the forge generated applications, I think we should make the same repositories changes in:

https://github.com/apache/grails-core/blob/7.0.x/grails-forge/grails-forge-core/src/main/java/org/grails/forge/build/gradle/GradleRepository.java#L41-L62

This will only impact Grails snapshots.

So duplicate the change instead of importing the plugin?

@jamesfredley
Copy link
Contributor

I see that plugin now, if it can be used in the grails-forge generated application, then let's use it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

2 participants