Skip to content

Conversation

@Ajay9704
Copy link
Contributor

@Ajay9704 Ajay9704 commented Jan 10, 2026

This PR addresses an issue where the grails-core repository was attempting to use the published org.apache.grails:grails-docs-core dependency which was removed in PR #15163 . The grails-docs-core functionality still exists in the codebase as a local build-logic component but was incorrectly referenced as a published artifact.

Changes Made

grails-doc/build.gradle: Updated dependency from 'org.apache.grails:grails-docs-core' to project(':grails-docs-core')
buildSrc/build.gradle: Updated dependency from 'org.apache.grails:grails-docs-core' to project(':grails-docs-core')

Context

The grails-docs-core module provides documentation generation functionality including:
FetchTagsTask - For fetching Git tags
CreateReleaseDropDownTask - For creating release dropdowns in documentation
PublishGuideTask - For publishing guides
This functionality continues to work as expected but now uses the local project dependency instead of trying to download a non-existent published artifact.

Impact

Fixes build failures when trying to resolve the removed published dependency
Maintains all existing documentation generation functionality
Aligns with the project's architecture of keeping build logic in the build-logic module

Copy link
Contributor

@jdaugherty jdaugherty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not believe this is the proper fix for #15163 .

  1. the project() changes are unnecessary because the gradle composite build already imports the build-logic build, which exports the grails-doc-core project as the dependency as org.apache.grails:grails-docs:core.

  2. This ticket requires us to move the grails-doc-core back to grails-gradle subproject & publish it. However, we need to adjust the build based on previous weekly discussions. I believe the suggested strategy was: 1. move the build back to grails-gradle 2. extract the templates into a separate area that's published separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants