Support for Gorm Entities with same name, but different packages

[codeconsole]

Currently RestfulServiceController will not work for situations where you have domain objects with the same name.

This scenario is more likely for complex websites that use plugins with domain objects.

For instance:

grails-app/domain/org/website/User.groovy
grails-app/domain/org/website/plugin/User.groovy

package org.website

import org.springframework.security.provisioning.UserDetailsManager

@Scaffold(GormService<User>)
class UserService implements UserDetailsManager {
    // implementation 
}

package org.website.plugin

@Scaffold(GormService<User>)
class MyPluginUserService  {
    //  implementation 
}

This introduces a fix that will resolve the appropriate service class for the respective GormService

[jdaugherty]

We need to add tests for this to merge it.

[codeconsole]

@jdaugherty the scaffolding plugin doesn't have any tests? Do you know of any?

This is a fix. If there are no existing tests, it is better to merge than to leave broken, no?

[jdaugherty]

@codeconsole We should add a functional test project. DomainServiceLocator appears more complex than it should be. How do we know an existing workflow didn't break without a test?

[codeconsole]

@jdaugherty

DomainServiceLocator appears more complex than it should be.

I've simplified it to its original intent. It now just only uses services of type GormService

How do we know an existing workflow didn't break without a test?

RestfulServiceController is a new class that is just an example of the Service Layer pattern. There are no existing workflows and it would be silly to just add 1 test to the entire plugin that only tests this.

[jdaugherty]

I've added this to Wednesday's developer meeting to see where people stand on this. I tried to point out in the review some possible problem points. I'm not 100% sure if it would cause compilation issues - but if it does we have to agree to do another RC.

[jdaugherty]

We should add a functional test for scaffolding - we should be able to easily add 2 examples of this scenario to prove this works.

[codeconsole]

@jdaugherty Are there existing functional tests for scaffolding? if so, do you have an explanation how they work?

[jdaugherty]

our functional test apps are under grails-test-examples/*. We do not have an existing app. We only want you to generate one and test the 2 scenarios. We do not think we need to test all of scaffolding, but as we add more features we need to start enhancing the tests.

[jdaugherty]

For example:

Add a subproject: grails-test-examples/scaffolding (can copy gsp or sitemesh if you want as a basis, the only thing that needs updated is settings.gradle & adding the files from grails-test-examples/scaffolding). Then just add your domain scenario & a geb test that calls the screen / makes sure it doesn't error.

We're not asking you to test every functionality of scaffolding. Just to grow the test coverage in this area as we make enhancements.

[jamesfredley]

For the scaffolding functional tests, the following existing test projects are a good place to copy as a quick starting point. These all use Geb w/ TestContainers.

https://github.com/apache/grails-core/tree/7.0.x/grails-test-examples/geb
https://github.com/apache/grails-core/tree/7.0.x/grails-test-examples/gsp-layout
https://github.com/apache/grails-core/tree/7.0.x/grails-test-examples/app1

[codeconsole]

For the scaffolding functional tests, the following existing test projects are a good place to copy as a quick starting point. These all use Geb w/ TestContainers.

https://github.com/apache/grails-core/tree/7.0.x/grails-test-examples/geb https://github.com/apache/grails-core/tree/7.0.x/grails-test-examples/gsp-layout https://github.com/apache/grails-core/tree/7.0.x/grails-test-examples/app1

@jamesfredley are there already functional tests for the scaffolding plugin in those examples? Where exactly are you saying to put it?