FLINK-37154: Adding SimpleByteSchema for PyFlink #26080
Open
+126
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@flinkbot run azure
Get Outlook for Android<https://aka.ms/AAb9ysg>
…________________________________
From: flinkbot ***@***.***>
Sent: Saturday, January 25, 2025 6:43:28 PM
To: apache/flink ***@***.***>
Cc: Chris ***@***.***>; Author ***@***.***>
Subject: Re: [apache/flink] FLINK-37154: Adding SimpleByteSchema for PyFlink (PR #26080)
CI report:
* a91b39a<a91b39a> UNKNOWN
Bot commands The @flinkbot<https://github.com/flinkbot> bot supports the following commands:
* @flinkbot run azure re-run the last Azure build
—
Reply to this email directly, view it on GitHub<#26080 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AARVEMLO2SKMBA4RTU2UWGD2MM6CBAVCNFSM6AAAAABV3CZJFCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMJTHAZDQMZZHE>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
|
@flinkbot run azure
…________________________________
From: flinkbot ***@***.***>
Sent: Saturday, 25 January 2025 6:43 PM
To: apache/flink ***@***.***>
Cc: Chris ***@***.***>; Author ***@***.***>
Subject: Re: [apache/flink] FLINK-37154: Adding SimpleByteSchema for PyFlink (PR #26080)
CI report:
* a91b39a<a91b39a> UNKNOWN
Bot commands The @flinkbot<https://github.com/flinkbot> bot supports the following commands:
* @flinkbot run azure re-run the last Azure build
—
Reply to this email directly, view it on GitHub<#26080 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AARVEMLO2SKMBA4RTU2UWGD2MM6CBAVCNFSM6AAAAABV3CZJFCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMJTHAZDQMZZHE>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
|
@flinkbot run azure |
|
From the discussion in the Jira it seems like this change was for Python datastream. I think introducing a Python raw format to Python would be more consistent with the way Java implements this. WDYT @MartijnVisser . naming nit: SimpleStringSchema is one String, I would read SimpleByteSchema as one byte, I suggested calling it ByteArraySchema. |
|
Reviewed by Chi on 30/01/2025 Go back to the submitter with review comments. |
|
@davidradl is the consensus to rename the class from SimpleByteSchema to ByteArraySchema? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This pull request enables PyFlink to consume Byte arrays from Kafka enabling consumption of binary formatted data. It is intended to be used similar to the SimpleStringSchema in the value serialiser configuration.
Brief change log
Verifying this change
This change added tests and can be verified as follows:
Does this pull request potentially affect one of the following parts:
@Public(Evolving): yesDocumentation