-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-37205][python] Correct the state cache behavior during bump beam version #26058
base: master
Are you sure you want to change the base?
Conversation
experiments = options.view_as(DebugOptions).experiments or [] | ||
for experiment in experiments: | ||
# There should only be 1 match so returning from the loop | ||
if re.match(r'state_cache_size=', experiment): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: if "state_cache_size=" in experiment:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there a way to add a unit test for this ?
Reviewed by Chi on 23/01/2025 Go back to the submitter with review comments. |
@davidradl Thanks for the comments. It's very difficult to add unit test for this. Besides, it's an inner behavior of Beam and I don't think we should test for it. It should happen very rarely. |
What is the purpose of the change
This pull request fixes the state cache behavior during bump beam version. It has changed the state cache strategy from size based to bytes based since Beam 2.42.0 (See apache/beam#22924 for more details). We should also support memory based state cache in the long term. Before that, we should correct the behavior which seems broken after bumping the Beam version. It may cause the state cache continuously increase and finally cause the job OOM.
Brief change log
(for example:)
Verifying this change
Please make sure both new and modified tests in this PR follow the conventions for tests defined in our code quality guide.
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: (no)Documentation