[FLINK-37194][tests] Fix NPE issue in WatermarkITCase #26048
+27
−78
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Fix NPE issue in WatermarkITCase.
The NPE is because here, the latter operation (i.e.
receivedWatermarks.computeIfAbsent
) might not be run immediately after the former operation (i.e.attemptIds.compute
).And during the main testing thread, we only wait for attemptIds size is expected. So, after the attemptIds size is expected, when we try to verify
assertOperatorReceivedWatermarkValues
, we might getnull
value because in the other thread, thereceivedWatermarks.computeIfAbsent
is not executed, yet.To fix this issue, we just need to wait for the
receivedWatermarks
size, not theattemptIds
size. But since this issue exists in many other test cases inWatermarkITCase
, I extracted the common codes into a helper method:submitJobAndWaitForOperator3Initialized
.Brief change log
Fix NPE issue in WatermarkITCase.
Verifying this change
This change is already covered by existing tests, such as (please describe tests).
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: noDocumentation