-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-37099][docs] Document memory/performance considerations and config possibilities for Netty4 #26043
base: master
Are you sure you want to change the base?
Conversation
…nfig possibilities for Netty4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I wonder if the netty 4 reflection setting should be enabled by default?
IMO it would still be safe top append it to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ferenc-csaky , LGTM.
I asked about this in the mailing list but I think it got lost. Isn't |
I'm not sure if it would be a good idea to bring Netty-specific memory mgmt to the Flink docs. Personally I'd rather keep this doc part as light as it can be, to make sure we do not add any noise and create confusion where users might shoot themselves in the foot. Mixing that with JVM memory handling props from Flink configs could result in undesired setups pretty easily IMO. |
@asardaes I agree with @ferenc-csaky . People who are running in such memory-constrained scenarios are welcome to investigate the details of Netty configuration. The documentation section is there primarily to indicate what is the reason for the change in behavior inside of Flink. The path for a "normal" Flink user would be to simply allocate slightly more overall memory to TMs/JM. |
In my experience with Netty outside of Flink, running with the default ( |
What is the purpose of the change
Add some guidance in the Flink docs about Netty4 memory and performance configs.
Verifying this change
Doc change
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: noDocumentation