-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[hotfix] Fix typo #26021
base: master
Are you sure you want to change the base?
[hotfix] Fix typo #26021
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, please could you use the hotfix in the title as per the process https://flink.apache.org/how-to-contribute/contribute-code/ and also include the Chinese version.
@@ -98,7 +98,7 @@ An example is as follows: | |||
```java | |||
DataStream<Tuple2<Integer, Integer>> dataStream = //... | |||
PartitionWindowedStream<Tuple2<Integer, Integer>> partitionWindowedDataStream = dataStream.fullWindowPartition(); | |||
DataStream<Integer> resultStream = partitionWindowedDataStream.aggregate(new ReduceFunction<>{...}); | |||
DataStream<Integer> resultStream = partitionWindowedDataStream.reduce(new ReduceFunction<>{...}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I notice you have fixed this at 1.20. Usually fixes are done in master and backported. Master seems to have this issue as well. Please can you ensure master is fixed as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems cannot fix two branch in one pull request, I changed base branch to master. Maybe I need create another pull request?
partitionWindowedDataStream.aggregate(new ReduceFunction<>{...}) should be partitionWindowedDataStream.reduce(new ReduceFunction<>{...})