Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hotfix] Fix typo #26021

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[hotfix] Fix typo #26021

wants to merge 1 commit into from

Conversation

yeoleobun
Copy link

partitionWindowedDataStream.aggregate(new ReduceFunction<>{...}) should be partitionWindowedDataStream.reduce(new ReduceFunction<>{...})

Copy link
Contributor

@davidradl davidradl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, please could you use the hotfix in the title as per the process https://flink.apache.org/how-to-contribute/contribute-code/ and also include the Chinese version.

@flinkbot
Copy link
Collaborator

flinkbot commented Jan 20, 2025

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@yeoleobun yeoleobun changed the title fix typo [hotfix] Fix typo Jan 20, 2025
@@ -98,7 +98,7 @@ An example is as follows:
```java
DataStream<Tuple2<Integer, Integer>> dataStream = //...
PartitionWindowedStream<Tuple2<Integer, Integer>> partitionWindowedDataStream = dataStream.fullWindowPartition();
DataStream<Integer> resultStream = partitionWindowedDataStream.aggregate(new ReduceFunction<>{...});
DataStream<Integer> resultStream = partitionWindowedDataStream.reduce(new ReduceFunction<>{...});
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I notice you have fixed this at 1.20. Usually fixes are done in master and backported. Master seems to have this issue as well. Please can you ensure master is fixed as well.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems cannot fix two branch in one pull request, I changed base branch to master. Maybe I need create another pull request?

@yeoleobun yeoleobun changed the base branch from release-1.20 to master January 21, 2025 01:01
@yeoleobun yeoleobun changed the base branch from master to release-1.20 January 21, 2025 01:03
@yeoleobun yeoleobun changed the base branch from release-1.20 to master January 21, 2025 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants