[FLINK-37192] [pyflink] Replace deprecated avro-python3 with avro #26008
+5
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mina-asham
force-pushed
the
minaasham/upgrade-replace-avro-python3
branch
from
7c11f44 to
8c67bb7
Compare
|
@mina-asham Thanks for the PR! LGTM overall. Could you create a JIRA ticket and also rebase the PR to fix the code conflict of file setup.py? |
mina-asham
force-pushed
the
minaasham/upgrade-replace-avro-python3
branch
2 times, most recently
from
8d2543b to
84398d2
Compare
|
@dianfu thanks for reviewing!
✅ Done |
- avro-python3 was deprecated and replaced by avro, the first hasn't had a release since March 17, 2021 while the second has had multiple fixes and updated, latest is August 5, 2024 - Both libraries are the exact same (i.e. `avro-python3` was just renamed to `avro` and had multiple updates since), but the problem is that they overlap in package name, so using PyFlink with any updated library that relies on `avro` fails starting the pipeline even if the pipeline doesn't actually do any avro encoding/decoding - This updates the library to the latest one, and fixes a few imports, other than that the library's functionality is exactly the same
mina-asham
force-pushed
the
minaasham/upgrade-replace-avro-python3
branch
from
84398d2 to
6239582
Compare
mina-asham
changed the title
|
@flinkbot run azure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Replace deprecated avro-python3 with avro
avro-python3was just renamed toavroand had multiple updates since), but the problem is that they overlap in package name, so using PyFlink with any updated library that relies onavrofails starting the pipeline even if the pipeline doesn't actually do any avro encoding/decodingBrief change log
avro-python3(deprecated since 2021) withavroin PyFlinkVerifying this change
This change is already covered by existing tests, such as all the existing avro tests
Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation