[FLINK-36926][table] Introduce window join operator with async state api #25815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xuyangzhong
force-pushed
the
FLINK-36926
branch
from
9aaf745 to
6786df0
Compare
xuyangzhong
force-pushed
the
FLINK-36926
branch
from
6786df0 to
5f9b5a6
Compare
davidradl
reviewed
Dec 20, 2024
| @@ -40,6 +41,16 @@ public ListStateDescriptor(String stateId, TypeInformation<T> typeInfo) { | |||
| super(stateId, typeInfo); | |||
| } | |||
|
|
|||
| /** | |||
| * Creates a new {@code ListStateDescriptor} with the given name and list element type. | |||
There was a problem hiding this comment.
list element type. -> the given type serializer.
davidradl
reviewed
Dec 20, 2024
| AbstractStreamOperator<?> abstractStreamOperator = (AbstractStreamOperator<?>) operator; | ||
| KeyedStateBackend<Object> keyedStateBackend = abstractStreamOperator.getKeyedStateBackend(); | ||
| KeyedStateBackend<?> keyedStateBackend; | ||
| if (operator instanceof AbstractAsyncStateStreamOperator) { |
There was a problem hiding this comment.
as reflection is quite costly and the operator is an instance variable, can we organize the code so the reflection is done once and caches rather than on every access. I know this is test code - but it could save some time.
|
CI failing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Introduce new Window Join Operator with Async State API.
Brief change log
Verifying this change
Existent tests and new added tests can verify this change.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation