FINERACT-2191: ThreadLocal context handling during job execution#4501
Merged
adamsaghy merged 1 commit intoapache:developfrom Mar 27, 2025
Conversation
oleksii-novikov-onix
force-pushed
the
FINERACT-2191/threadLocal-context-handling-during-job-execution
branch
3 times, most recently
from
a15738a to
e933347
Compare
adamsaghy
reviewed
Mar 26, 2025
| String tenantIdentifier = ThreadLocalContextUtil.getTenant().getTenantIdentifier(); | ||
|
|
||
| while (!DateUtils.isAfter(executingBusinessDate, cobBusinessDate)) { | ||
| // Need to reinitialize the thread-local tenant info because after running the job, it resets the thread |
Contributor
There was a problem hiding this comment.
Are you sure we dont need to reinit the context once a job was executed?
The job started reset the context once finished, no?
Contributor
Author
There was a problem hiding this comment.
I think we don't need to reinitialize the context here(on while iteration level), because it's already initialized in JobStarter.run. Of course, we don’t do a full initialization using ThreadLocalContextUtil.init, but we do initialize the tenant, business date, and action context. Then, there's another initialization in InitialisationTasklet.execute. Another important change here is that we pass the tenant as a job parameter.
oleksii-novikov-onix
force-pushed
the
FINERACT-2191/threadLocal-context-handling-during-job-execution
branch
from
e933347 to
0d904cc
Compare
oleksii-novikov-onix
force-pushed
the
FINERACT-2191/threadLocal-context-handling-during-job-execution
branch
from
0d904cc to
e4907d1
Compare
adamsaghy
deleted the
FINERACT-2191/threadLocal-context-handling-during-job-execution
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated Apache Fineract JIRA ticket.
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Write the commit message as per https://github.com/apache/fineract/#pull-requests
Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
Create/update unit or integration tests for verifying the changes made.
Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.