FINERACT-1806: Charge-off Expense Accounting entries based on charge-off reason instead of fraud flag #4144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kulminsky
force-pushed
the
FINERACT-1806/Charge-off-Expense-Accounting-entries-based-on-charge-off-reason-instead-of-fraud-flag
branch
from
ad84a5b
to
8ecfc1f
Compare
adamsaghy
reviewed
Nov 6, 2024
| @@ -30,7 +30,9 @@ public enum AccountingRuleType { | |||
| NONE(1, "accountingRuleType.none", "No accounting"), // | |||
| CASH_BASED(2, "accountingRuleType.cash", "Cash based accounting"), // | |||
| ACCRUAL_PERIODIC(3, "accountingRuleType.accrual.periodic", "Periodic accrual accounting"), // | |||
| ACCRUAL_UPFRONT(4, "accountingRuleType.accrual.upfront", "Upfront accrual accounting"); // | |||
| ACCRUAL_UPFRONT(4, "accountingRuleType.accrual.upfront", "Upfront accrual accounting"), // | |||
| CHARGE_OFF_FRAUD(5, "accountingRuleType.chargeOffFraud", "Charge-off accounting for fraud"), CHARGE_OFF_DELINQUENT(6, | |||
There was a problem hiding this comment.
Charge-off is not a separate accounting rule type. Please undo this.
adamsaghy
reviewed
Nov 6, 2024
| @@ -209,6 +209,16 @@ public void createLoanProductToGLAccountMapping(final Long loanProductId, final | |||
| this.loanProductToGLAccountMappingHelper.savePaymentChannelToFundSourceMappings(command, element, loanProductId, null); | |||
| this.loanProductToGLAccountMappingHelper.saveChargesToIncomeAccountMappings(command, element, loanProductId, null); | |||
| break; | |||
| case CHARGE_OFF_FRAUD: | |||
There was a problem hiding this comment.
We dont need this.... we should save all the configured mapping, but we dont need to differentiate them yet
adamsaghy
reviewed
Nov 6, 2024
| private static final int FINANCIAL_ACCOUNT_TYPE_EXPENSE = GLAccountType.EXPENSE.getValue(); | ||
| private static final String CHARGE_OFF_FRAUD_EXPENSE = LoanProductAccountingParams.CHARGE_OFF_FRAUD_EXPENSE.getValue(); | ||
|
|
||
| @BeforeEach |
There was a problem hiding this comment.
I dont see any added value of having classes that are fully mocked out... I would rather see integration test that is testing whether incoming request got saved properly, and we can fetch created mappings. It can be updated, etc.
kulminsky
force-pushed
the
FINERACT-1806/Charge-off-Expense-Accounting-entries-based-on-charge-off-reason-instead-of-fraud-flag
branch
from
8ecfc1f
to
c392b6b
Compare
adamsaghy
reviewed
Nov 7, 2024
| @@ -388,4 +388,15 @@ private GLAccountType getGLAccountType(final JsonElement element, final String p | |||
| return gLAccountType; | |||
| } | |||
|
|
|||
| public void mapChargeOffReasonToExpenseAccount(JsonElement element, Long loanProductId, String expenseAccountParam) { | |||
There was a problem hiding this comment.
I guess we dont need this anymore
adamsaghy
reviewed
Nov 7, 2024
| @@ -208,6 +208,7 @@ public void createLoanProductToGLAccountMapping(final Long loanProductId, final | |||
| // advanced accounting mappings | |||
| this.loanProductToGLAccountMappingHelper.savePaymentChannelToFundSourceMappings(command, element, loanProductId, null); | |||
| this.loanProductToGLAccountMappingHelper.saveChargesToIncomeAccountMappings(command, element, loanProductId, null); | |||
| this.loanProductToGLAccountMappingHelper.saveChargeOffReasonToExpenseAccountMappings(command, element, loanProductId, null); | |||
There was a problem hiding this comment.
Dont forget to add to CASH_BASED accounting as well
kulminsky
force-pushed
the
FINERACT-1806/Charge-off-Expense-Accounting-entries-based-on-charge-off-reason-instead-of-fraud-flag
branch
2 times, most recently
from
20f03cf
to
e4f92fd
Compare
…nced Accounting Rule"
kulminsky
force-pushed
the
FINERACT-1806/Charge-off-Expense-Accounting-entries-based-on-charge-off-reason-instead-of-fraud-flag
branch
from
e4f92fd
to
8712a40
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Charge-off Expense Accounting entries based on charge-off reason instead of fraud flag
Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated Apache Fineract JIRA ticket.
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Write the commit message as per https://github.com/apache/fineract/#pull-requests
Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
Create/update unit or integration tests for verifying the changes made.
Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.