Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datazoom): prevent bar and scatter chart overflowing the graph . … #20718

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

akashsonune
Copy link

@akashsonune akashsonune commented Jan 24, 2025

close #19972

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

The PR prevents bars and scatter chart from going outside of the graph when zoomed in

Fixed issues

#19972

Details

Before: What was the problem?

In case the filtermode: 'none' and series type is bar or scatter and x axiis type is time, on zooming in too much, the bars would go outside of the graph (beyond axis)

After: How does it behave after the fixing?

The bars and scatter chart stays within the axis.

Document Info

One of the following should be checked.

  • This PR doesn't relate to document changes
  • The document should be updated later
  • The document changes have been made in apache/echarts-doc#xxx

Misc

ZRender Changes

  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

N.A.

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

Copy link

echarts-bot bot commented Jan 24, 2025

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

⚠️ MISSING DOCUMENT INFO: Please make sure one of the document options are checked in this PR's description. Search "Document Info" in the description of this PR. This should be done either by the author or the reviewers of the PR.

@akashsonune akashsonune marked this pull request as draft January 24, 2025 17:59
@akashsonune akashsonune marked this pull request as ready for review January 27, 2025 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Bar Chart bars overflow out of the coordinate system
1 participant