fix(legend): symbolRotate for legend is neither inherited nor being set #20562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The changes brought by this PR can be previewed at: https://echarts.apache.org/examples/editor?version=PR-20562@3af0b83 |
Ovilia
requested changes
Dec 12, 2024
| @@ -404,7 +404,8 @@ class LegendView extends ComponentView { | |||
| } | |||
| else { | |||
| // Use default legend icon policy for most series | |||
| const rotate = legendIconType === 'inherit' && seriesModel.getData().getVisual('symbol') | |||
| const rotate = (!legendIconType || legendIconType === 'inherit') | |||
There was a problem hiding this comment.
I think this may not be quite accurate.
Consider the series that doesn't have seriesModel.getLegendIcon, like pie series, with legend.symbolRotate = 30, we may probably expect the legend icon is a roundRect with rotation of 30 degrees. But instead, the current implementation uses 0. I didn't consider this situation when in my previous PR. Can you help fix this?
My guess would be something like zrUtil.retrive2(seriesModel.getData().getVisual('symbolRotate'), iconRotate) but you may need to figure out what works by doing more tests.
Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief Information
This pull request is in the type of:
What does this PR do?
Fixed issues
#20559
#17955
Details
Before: What was the problem?
symbolRotatefor legend is neither inherited nor being set in case of scatter series.After: How does it behave after the fixing?
symbolRotatework well in legendDocument Info
One of the following should be checked.
Misc
ZRender Changes
Related test cases or examples to use the new APIs
N.A.
Others
Merging options
Other information