Skip to content

[GSoC 2025] Add discovery-timeline QoS command to display real-time service discovery metadata #15590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 14 commits into
base: 3.3
Choose a base branch
from
Open

[GSoC 2025] Add discovery-timeline QoS command to display real-time service discovery metadata #15590

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
855646f
[Enhancement] Add discovery-timeline QoS command for service discover…
ankitshokeen Jul 27, 2025
67ddb33
Merge branch '3.3' into feature/discovery-timeline
ankitshokeen Jul 27, 2025
f994f18
fix/formatting
ankitshokeen Jul 28, 2025
b446f9d
Merge branch '3.3' into feature/discovery-timeline
ankitshokeen Jul 28, 2025
b9bfc4c
Delete redundant configuration
zrlw Jul 29, 2025
1f4a4eb
Update pom.xml
zrlw Jul 29, 2025
9743d31
fix(qos): add ASF license header and use proper logger codes in Disco…
ankitshokeen Jul 29, 2025
2c06cac
Merge branch '3.3' into feature/discovery-timeline
ankitshokeen Jul 29, 2025
6a99568
revert
ankitshokeen Jul 29, 2025
6839f23
migrate to logger
ankitshokeen Jul 30, 2025
b9b4995
fix formatting issues
ankitshokeen Jul 30, 2025
c4a89a1
Update org.apache.dubbo.qos.api.BaseCommand
zrlw Jul 31, 2025
04b7a9a
Update pom.xml
zrlw Jul 31, 2025
3bd9d97
Merge branch '3.3' into feature/discovery-timeline
ankitshokeen Aug 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion ...mo-spring-boot-idl/dubbo-demo-spring-boot-idl-consumer/src/main/resources/application.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,4 +32,3 @@ dubbo:
metadata-report:
address: zookeeper://127.0.0.1:2181


42 changes: 42 additions & 0 deletions dubbo-plugin/dubbo-qos/META-INF/dubbo/internal/org.apache.dubbo.qos.api.BaseCommand
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
online=org.apache.dubbo.qos.command.impl.Online
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete this file because it has already existed in resources

onlineApp=org.apache.dubbo.qos.command.impl.OnlineApp
onlineInterface=org.apache.dubbo.qos.command.impl.OnlineInterface
help=org.apache.dubbo.qos.command.impl.Help
quit=org.apache.dubbo.qos.command.impl.Quit
ls=org.apache.dubbo.qos.command.impl.Ls
offline=org.apache.dubbo.qos.command.impl.Offline
offlineApp=org.apache.dubbo.qos.command.impl.OfflineApp
offlineInterface=org.apache.dubbo.qos.command.impl.OfflineInterface
ready=org.apache.dubbo.qos.command.impl.Ready
startup=org.apache.dubbo.qos.command.impl.Startup
live=org.apache.dubbo.qos.command.impl.Live
version=org.apache.dubbo.qos.command.impl.Version
publishMetadata=org.apache.dubbo.qos.command.impl.PublishMetadata
cd=org.apache.dubbo.qos.command.impl.ChangeTelnet
count=org.apache.dubbo.qos.command.impl.CountTelnet
pwd=org.apache.dubbo.qos.command.impl.PwdTelnet
invoke=org.apache.dubbo.qos.command.impl.InvokeTelnet
select=org.apache.dubbo.qos.command.impl.SelectTelnet
ps=org.apache.dubbo.qos.command.impl.PortTelnet
shutdown=org.apache.dubbo.qos.command.impl.ShutdownTelnet
enableDetailProfiler=org.apache.dubbo.qos.command.impl.EnableDetailProfiler
disableDetailProfiler=org.apache.dubbo.qos.command.impl.DisableDetailProfiler
enableSimpleProfiler=org.apache.dubbo.qos.command.impl.EnableSimpleProfiler
disableSimpleProfiler=org.apache.dubbo.qos.command.impl.DisableSimpleProfiler
setProfilerWarnPercent=org.apache.dubbo.qos.command.impl.SetProfilerWarnPercent
getRouterSnapshot=org.apache.dubbo.qos.command.impl.GetRouterSnapshot
getEnabledRouterSnapshot=org.apache.dubbo.qos.command.impl.GetEnabledRouterSnapshot
enableRouterSnapshot=org.apache.dubbo.qos.command.impl.EnableRouterSnapshot
disableRouterSnapshot=org.apache.dubbo.qos.command.impl.DisableRouterSnapshot
getRecentRouterSnapshot=org.apache.dubbo.qos.command.impl.GetRecentRouterSnapshot
loggerInfo=org.apache.dubbo.qos.command.impl.LoggerInfo
switchLogger=org.apache.dubbo.qos.command.impl.SwitchLogger
switchLogLevel=org.apache.dubbo.qos.command.impl.SwitchLogLevel
serializeCheckStatus=org.apache.dubbo.qos.command.impl.SerializeCheckStatus
serializeWarnedClasses=org.apache.dubbo.qos.command.impl.SerializeWarnedClasses
getConfig=org.apache.dubbo.qos.command.impl.GetConfig
getAddress=org.apache.dubbo.qos.command.impl.GetAddress
gracefulShutdown=org.apache.dubbo.qos.command.impl.GracefulShutdown
metrics_default=org.apache.dubbo.qos.command.impl.DefaultMetricsReporterCmd
getOpenAPI=org.apache.dubbo.qos.command.impl.GetOpenAPI
discovery-timeline=org.apache.dubbo.qos.command.impl.DiscoveryTimelineCommand
103 changes: 98 additions & 5 deletions dubbo-plugin/dubbo-qos/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,13 @@
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
-->
-->
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
<modelVersion>4.0.0</modelVersion>
<parent>
<groupId>org.apache.dubbo</groupId>
<artifactId>dubbo-parent</artifactId>
<version>${revision}</version>
<version>3.3.6-SNAPSHOT</version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use revision

<relativePath>../../pom.xml</relativePath>
</parent>

Expand All @@ -34,6 +34,18 @@
<skip_maven_deploy>false</skip_maven_deploy>
</properties>

<dependencyManagement>
Copy link
Contributor

@RainYuY RainYuY Jul 28, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need to import it because it's already managed by the parent dependencyManagement.

<dependencies>
<dependency>
<groupId>org.apache.dubbo</groupId>
<artifactId>dubbo-dependencies-bom</artifactId>
<version>${project.version}</version>
<type>pom</type>
<scope>import</scope>
</dependency>
</dependencies>
</dependencyManagement>

<dependencies>
<dependency>
<groupId>org.apache.dubbo</groupId>
Expand Down Expand Up @@ -65,11 +77,10 @@
<artifactId>dubbo-serialization-hessian2</artifactId>
<version>${project.version}</version>
</dependency>

<dependency>
<groupId>org.apache.dubbo</groupId>
<artifactId>dubbo-serialization-fastjson2</artifactId>
<version>${project.parent.version}</version>
<version>${project.version}</version>
</dependency>
<dependency>
<groupId>org.apache.dubbo</groupId>
Expand All @@ -79,7 +90,7 @@
<dependency>
<groupId>org.apache.dubbo</groupId>
<artifactId>dubbo-native</artifactId>
<version>${project.parent.version}</version>
<version>${project.version}</version>
</dependency>
<dependency>
<groupId>org.apache.dubbo</groupId>
Expand All @@ -89,7 +100,89 @@
<dependency>
<groupId>org.apache.logging.log4j</groupId>
<artifactId>log4j-slf4j-impl</artifactId>
<version>2.24.3</version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete all your added dependencies because these artifacts have already been added for testing.

<scope>test</scope>
</dependency>
<dependency>
<groupId>org.junit.jupiter</groupId>
<artifactId>junit-jupiter-api</artifactId>
<version>5.10.3</version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All versions should be defined in dependencyManagement.

<scope>test</scope>
</dependency>
<dependency>
<groupId>org.junit.jupiter</groupId>
<artifactId>junit-jupiter-engine</artifactId>
<version>5.10.3</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.junit.platform</groupId>
<artifactId>junit-platform-commons</artifactId>
<version>1.10.3</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.junit.platform</groupId>
<artifactId>junit-platform-engine</artifactId>
<version>1.10.3</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.junit.platform</groupId>
<artifactId>junit-platform-launcher</artifactId>
<version>1.10.3</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.mockito</groupId>
<artifactId>mockito-core</artifactId>
<version>4.11.0</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.mockito</groupId>
<artifactId>mockito-inline</artifactId>
<version>4.11.0</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.hamcrest</groupId>
<artifactId>hamcrest</artifactId>
<version>2.2</version>
<scope>test</scope>
</dependency>
</dependencies>

<build>
Copy link
Contributor

@zrlw zrlw Jul 28, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete it because building configuration should be managed by dubbo-parent for building dubbo with different jdk versions.

<plugins>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
<version>3.14.0</version>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-surefire-plugin</artifactId>
<version>3.5.3</version>
<configuration>
<includes>
<include>**/*Test.java</include>
</includes>
</configuration>
</plugin>
<plugin>
<groupId>com.diffplug.spotless</groupId>
<artifactId>spotless-maven-plugin</artifactId>
<version>2.44.4</version>
<executions>
<execution>
<goals>
<goal>check</goal>
</goals>
<phase>validate</phase>
</execution>
</executions>
</plugin>
</plugins>
</build>
</project>
Loading
Loading