Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: the issue of possible infinite loop when cleaning up expired metadata info #15086

Open
wants to merge 7 commits into
base: 3.3
Choose a base branch
from

Conversation

funky-eyes
Copy link
Contributor

@funky-eyes funky-eyes commented Jan 22, 2025

What is the purpose of the change?

fix #15087

Checklist

  • Make sure there is a GitHub_issue field for the change.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Make sure gitHub actions can pass. Why the workflow is failing and how to fix it?

@codecov-commenter
Copy link

codecov-commenter commented Jan 22, 2025

Codecov Report

Attention: Patch coverage is 94.44444% with 1 line in your changes missing coverage. Please review.

Project coverage is 60.76%. Comparing base (628dcbf) to head (0c7f59b).

Files with missing lines Patch % Lines
...ubbo/registry/client/AbstractServiceDiscovery.java 94.44% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                3.3   #15086      +/-   ##
============================================
- Coverage     60.76%   60.76%   -0.01%     
- Complexity    10863    10865       +2     
============================================
  Files          1882     1882              
  Lines         86007    86007              
  Branches      12886    12887       +1     
============================================
- Hits          52263    52262       -1     
- Misses        28301    28304       +3     
+ Partials       5443     5441       -2     
Flag Coverage Δ
integration-tests 32.99% <16.66%> (+0.01%) ⬆️
samples-tests 29.09% <16.66%> (-0.13%) ⬇️
unit-tests 58.93% <94.44%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] The service enters an infinite loop of metadata cache cleanup under frequent registration.
2 participants