[fix](cloud) CloudUpgradeMgr inspect and abort failed conflict txns while waiting#60830
Open
deardeng wants to merge 3 commits intoapache:masterfrom
Open
[fix](cloud) CloudUpgradeMgr inspect and abort failed conflict txns while waiting#60830deardeng wants to merge 3 commits intoapache:masterfrom
deardeng wants to merge 3 commits intoapache:masterfrom
Conversation
…hile waiting When CloudUpgradeMgr waits for unfinished transactions after registering watershed txn ids, it now proactively inspects conflict transactions for the target db/table set and logs sampled txn details for diagnosis. If enable_abort_txn_by_checking_conflict_txn is enabled, the manager invokes GlobalTransactionMgr.checkFailedTxns() and aborts failed txns to reduce the chance of upgrade being blocked by stale/conflicting txns. Abort failures are handled per txn and do not stop processing the rest. This commit also adds tests: - FE UT CloudUpgradeMgrTest to verify enabled/disabled behavior and continue-on-abort-error semantics. - cloud multi_cluster docker regression case test_unfinished_txn_2pc.groovy to reproduce and validate long-running unfinished 2PC txn behavior.
deardeng
requested review from
dataroaring,
gavinchou and
w41ter
as code owners
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 28808 ms |
TPC-DS: Total hot run time: 184147 ms |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 28991 ms |
TPC-DS: Total hot run time: 184238 ms |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When CloudUpgradeMgr waits for unfinished transactions after registering
watershed txn ids, it now proactively inspects conflict transactions for
the target db/table set and logs sampled txn details for diagnosis.
If enable_abort_txn_by_checking_conflict_txn is enabled, the manager
invokes GlobalTransactionMgr.checkFailedTxns() and aborts failed txns to
reduce the chance of upgrade being blocked by stale/conflicting txns.
Abort failures are handled per txn and do not stop processing the rest.
This commit also adds tests:
FE UT CloudUpgradeMgrTest to verify enabled/disabled behavior and
continue-on-abort-error semantics.
cloud multi_cluster docker regression case test_unfinished_txn_2pc.groovy
to reproduce and validate long-running unfinished 2PC txn behavior.
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)