-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix](restore) Make the DirMoveTask idempotent. #47313
base: master
Are you sure you want to change the base?
Conversation
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
run buildall |
TPC-H: Total hot run time: 32385 ms
|
TPC-DS: Total hot run time: 195178 ms
|
TeamCity be ut coverage result: |
ClickBench: Total hot run time: 30.94 s
|
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Since the DirMoveTask is executed asynchronously, the FE might send the task again to ensure its completion eventually. But the rowsets committed during two DirMoveTasks (if any) will be dropped, which causes the data loss.
This PR adds a LOADED tag file to indicate that the snapshot has been loaded into a tablet and should not be reloaded again.
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)