-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[opt](profile) Disable profile for insert into values and other commands #47296
base: master
Are you sure you want to change the base?
Conversation
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
run buildall |
run buildall |
TPC-H: Total hot run time: 32873 ms
|
TPC-DS: Total hot run time: 194441 ms
|
ClickBench: Total hot run time: 31.4 s
|
run p0 |
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
|
||
if (plan instanceof InsertIntoTableCommand) { | ||
LogicalPlan logicalPlan = ((InsertIntoTableCommand) plan).getLogicalQuery(); | ||
if (logicalPlan instanceof UnboundTableSink) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what if UnboundJdbcSink or UnboundHiveSink? is it safe for them to generate profile not like olap table?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed by adding UnboundBaseExternalTableSink
run buildall |
TPC-H: Total hot run time: 32048 ms
|
TPC-DS: Total hot run time: 187748 ms
|
ClickBench: Total hot run time: 31.3 s
|
What problem does this PR solve?
Profile of
INSERT INTO VALUES
and other ddl commands is disabled.Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)