Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[opt](inverted index)Optimize code to get rid of heap use after free (#45745) #46075

Merged
merged 2 commits into from
Dec 27, 2024
Merged

[opt](inverted index)Optimize code to get rid of heap use after free (#45745) #46075

merged 2 commits into from
Dec 27, 2024

Conversation

qidaye
Copy link
Contributor

@qidaye qidaye commented Dec 27, 2024

bp #45745

@qidaye
[opt](inverted index)Optimize code to get rid of heap use after free (a…
636b26a 
…pache#45745)

Problem Summary:
related: apache#45715
It will not coredump in master branch, but we should correct the
destruct order.
@Thearas
Copy link
Contributor

Thearas commented Dec 27, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@qidaye
Copy link
Contributor Author

qidaye commented Dec 27, 2024

run buildall

@qidaye
Copy link
Contributor Author

qidaye commented Dec 27, 2024

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.38% (9539/26217)
Line Coverage: 27.88% (78537/281714)
Region Coverage: 26.57% (40338/151838)
Branch Coverage: 23.32% (20425/87592)
Coverage Report: http://coverage.selectdb-in.cc/coverage/e90ad3d818a54c6390225795300610c852ce067f_e90ad3d818a54c6390225795300610c852ce067f/report/index.html

zzzxl1993
zzzxl1993 approved these changes Dec 27, 2024
View reviewed changes
Copy link
Contributor

@zzzxl1993 zzzxl1993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@qidaye qidaye merged commit 4746e9e into apache:branch-2.1 Dec 27, 2024
18 of 20 checks passed
@qidaye qidaye deleted the pick_opt_index_writer branch December 27, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zzzxl1993 zzzxl1993 zzzxl1993 approved these changes

Assignees
No one assigned
Labels
reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@qidaye @Thearas @doris-robot @zzzxl1993