Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

branch-3.0: [opt](inverted index)Optimize code to get rid of heap use after free #45745 #46051

Merged
merged 1 commit into from
Dec 27, 2024

Conversation

github-actions[bot]
Copy link
Contributor

Cherry-picked from #45745

…45745)

Problem Summary:
related: #45715
It will not coredump in master branch, but we should correct the
destruct order.
@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Dec 26, 2024
@hello-stephen
Copy link
Contributor

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 41050 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit b582510cd0e280841c2150b31fca160271922473, data reload: false

------ Round 1 ----------------------------------
q1	17584	7540	7322	7322
q2	2054	203	177	177
q3	10517	1096	1147	1096
q4	10596	758	674	674
q5	7778	2884	2887	2884
q6	242	151	146	146
q7	978	614	601	601
q8	9356	1980	2033	1980
q9	6635	6446	6485	6446
q10	6994	2280	2342	2280
q11	457	272	269	269
q12	410	214	208	208
q13	17801	3004	3037	3004
q14	246	212	210	210
q15	568	515	525	515
q16	699	615	619	615
q17	989	564	526	526
q18	7304	6753	6783	6753
q19	1387	1069	1016	1016
q20	478	210	201	201
q21	4213	3154	3237	3154
q22	1113	989	973	973
Total cold run time: 108399 ms
Total hot run time: 41050 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7300	7204	7189	7189
q2	330	227	228	227
q3	2932	2971	2957	2957
q4	2065	1804	1825	1804
q5	5715	5745	5765	5745
q6	229	141	143	141
q7	2230	1810	1820	1810
q8	3382	3571	3524	3524
q9	8881	8931	8924	8924
q10	3602	3556	3565	3556
q11	598	493	500	493
q12	834	640	657	640
q13	10350	3112	3154	3112
q14	319	276	271	271
q15	573	521	526	521
q16	695	662	700	662
q17	1861	1647	1590	1590
q18	8247	7731	7615	7615
q19	1678	1627	1577	1577
q20	2146	1855	1879	1855
q21	5643	5438	5365	5365
q22	1153	1085	1045	1045
Total cold run time: 70763 ms
Total hot run time: 60623 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 197105 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit b582510cd0e280841c2150b31fca160271922473, data reload: false

query1	1264	932	907	907
query2	6243	2101	2028	2028
query3	10798	4190	4137	4137
query4	65859	29360	23731	23731
query5	4980	462	454	454
query6	421	174	166	166
query7	5559	316	307	307
query8	318	218	218	218
query9	8974	2659	2662	2659
query10	457	271	257	257
query11	17324	15450	15847	15450
query12	149	102	100	100
query13	1468	458	430	430
query14	10443	6795	7138	6795
query15	206	192	182	182
query16	7104	480	495	480
query17	1060	575	573	573
query18	2062	329	331	329
query19	237	168	157	157
query20	115	113	109	109
query21	59	46	45	45
query22	4729	4461	4523	4461
query23	34693	34263	34346	34263
query24	6106	2890	2869	2869
query25	523	394	395	394
query26	674	168	165	165
query27	1975	305	301	301
query28	4201	2505	2455	2455
query29	708	452	433	433
query30	237	175	164	164
query31	992	814	839	814
query32	70	52	52	52
query33	392	284	280	280
query34	919	514	493	493
query35	867	729	738	729
query36	1100	960	976	960
query37	127	77	72	72
query38	4042	4033	4042	4033
query39	1493	1475	1465	1465
query40	134	79	82	79
query41	49	43	47	43
query42	113	96	94	94
query43	535	497	490	490
query44	1179	831	873	831
query45	184	172	166	166
query46	1177	759	711	711
query47	2010	1894	1934	1894
query48	467	396	402	396
query49	729	411	386	386
query50	839	438	422	422
query51	7462	7057	7240	7057
query52	96	82	80	80
query53	248	175	178	175
query54	562	440	448	440
query55	75	73	75	73
query56	252	233	232	232
query57	1242	1113	1091	1091
query58	206	207	201	201
query59	3087	2901	2900	2900
query60	281	249	254	249
query61	111	109	112	109
query62	786	677	667	667
query63	209	189	190	189
query64	1395	669	649	649
query65	3224	3163	3262	3163
query66	698	287	299	287
query67	16258	15713	15578	15578
query68	3763	610	581	581
query69	426	266	264	264
query70	1202	1103	1140	1103
query71	328	251	262	251
query72	6286	4103	4065	4065
query73	749	342	348	342
query74	9956	9003	8986	8986
query75	3337	2621	2666	2621
query76	1948	1107	1185	1107
query77	497	261	262	261
query78	10403	9752	9562	9562
query79	1397	602	590	590
query80	821	437	424	424
query81	496	240	235	235
query82	1278	114	111	111
query83	155	146	147	146
query84	287	77	81	77
query85	868	305	289	289
query86	339	292	288	288
query87	4455	4238	4208	4208
query88	3619	2378	2350	2350
query89	408	290	277	277
query90	1987	188	184	184
query91	184	148	147	147
query92	66	48	47	47
query93	1265	548	545	545
query94	776	286	285	285
query95	356	257	250	250
query96	611	274	283	274
query97	3352	3159	3191	3159
query98	226	202	206	202
query99	1576	1316	1305	1305
Total cold run time: 315973 ms
Total hot run time: 197105 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 32.87 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit b582510cd0e280841c2150b31fca160271922473, data reload: false

query1	0.03	0.03	0.04
query2	0.07	0.03	0.03
query3	0.23	0.06	0.06
query4	1.62	0.10	0.10
query5	0.53	0.52	0.49
query6	1.13	0.74	0.73
query7	0.02	0.02	0.02
query8	0.04	0.03	0.02
query9	0.57	0.48	0.50
query10	0.55	0.55	0.56
query11	0.14	0.11	0.11
query12	0.15	0.12	0.11
query13	0.61	0.59	0.59
query14	3.00	2.93	3.00
query15	0.91	0.83	0.82
query16	0.37	0.40	0.39
query17	1.08	1.05	0.99
query18	0.24	0.21	0.22
query19	1.92	1.74	1.97
query20	0.01	0.01	0.03
query21	15.36	0.62	0.59
query22	2.51	2.53	2.33
query23	17.08	1.08	0.75
query24	3.35	1.08	0.58
query25	0.18	0.11	0.24
query26	0.30	0.17	0.15
query27	0.05	0.04	0.04
query28	10.80	1.11	1.07
query29	12.60	3.25	3.24
query30	0.25	0.06	0.06
query31	2.86	0.39	0.38
query32	3.26	0.46	0.48
query33	2.98	3.05	3.04
query34	16.69	4.40	4.52
query35	4.48	4.48	4.46
query36	0.64	0.50	0.49
query37	0.10	0.06	0.06
query38	0.04	0.03	0.04
query39	0.04	0.02	0.02
query40	0.16	0.14	0.13
query41	0.08	0.02	0.03
query42	0.04	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 107.11 s
Total hot run time: 32.87 s

@qidaye qidaye merged commit 949ad8b into branch-3.0 Dec 27, 2024
20 of 21 checks passed
@qidaye qidaye deleted the auto-pick-45745-branch-3.0 branch December 27, 2024 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants