Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor](metrics) Remove IntAtomicCounter & CoreLocal #45742 #45871

Merged

Conversation

zhiqiang-hhhh
Copy link
Contributor

cherry pick from #45742

1. Remove `IntAtomicCounter`, it is equal to `IntCounter`.
2. Remove `CoreLocal` related code. It is not used any more.
@zhiqiang-hhhh
Copy link
Contributor Author

run buildall

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@doris-robot
Copy link

TPC-H: Total hot run time: 40369 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 8a5a8b0c3ebb80f8a8d6d531ca848d3b6d3cab58, data reload: false

------ Round 1 ----------------------------------
q1	17623	7447	7225	7225
q2	2063	178	182	178
q3	10677	1050	1119	1050
q4	10539	751	763	751
q5	7742	2881	2843	2843
q6	235	148	140	140
q7	982	610	603	603
q8	9587	1984	2058	1984
q9	7613	6396	6416	6396
q10	7000	2244	2334	2244
q11	461	260	282	260
q12	404	218	215	215
q13	17793	2962	3014	2962
q14	231	203	205	203
q15	560	514	517	514
q16	681	619	625	619
q17	979	558	509	509
q18	7332	6593	6422	6422
q19	2241	1044	989	989
q20	464	212	197	197
q21	3988	3227	3106	3106
q22	1078	1010	959	959
Total cold run time: 110273 ms
Total hot run time: 40369 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7536	7155	7143	7143
q2	329	227	233	227
q3	2946	2881	2873	2873
q4	2082	1820	1778	1778
q5	5697	5723	5735	5723
q6	232	141	145	141
q7	2195	1774	1756	1756
q8	3375	3559	3401	3401
q9	8850	8890	8854	8854
q10	3587	3539	3535	3535
q11	603	488	510	488
q12	813	632	644	632
q13	16561	3116	3109	3109
q14	301	270	260	260
q15	571	536	522	522
q16	720	690	657	657
q17	1896	1647	1587	1587
q18	8072	7829	7613	7613
q19	9324	1621	1591	1591
q20	2100	1839	1877	1839
q21	5419	5285	5264	5264
q22	1090	1000	1011	1000
Total cold run time: 84299 ms
Total hot run time: 59993 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 195568 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 8a5a8b0c3ebb80f8a8d6d531ca848d3b6d3cab58, data reload: false

query1	1327	953	923	923
query2	6237	2059	2015	2015
query3	10815	4162	3987	3987
query4	65851	29116	23598	23598
query5	5350	455	457	455
query6	472	186	205	186
query7	5682	327	312	312
query8	322	231	227	227
query9	9484	2720	2662	2662
query10	536	268	276	268
query11	17726	15169	15708	15169
query12	159	97	104	97
query13	1539	439	426	426
query14	9938	7607	6649	6649
query15	220	183	201	183
query16	7172	526	457	457
query17	1056	569	567	567
query18	1850	316	311	311
query19	230	152	149	149
query20	117	115	110	110
query21	65	48	42	42
query22	4727	4616	4560	4560
query23	34778	34256	34047	34047
query24	6154	2919	2987	2919
query25	520	382	395	382
query26	673	171	171	171
query27	1925	295	299	295
query28	4378	2521	2483	2483
query29	678	455	438	438
query30	249	167	160	160
query31	1025	815	834	815
query32	65	51	54	51
query33	487	279	266	266
query34	924	518	513	513
query35	834	728	753	728
query36	1095	969	941	941
query37	123	72	72	72
query38	4154	4089	3942	3942
query39	1514	1493	1468	1468
query40	145	83	88	83
query41	55	53	52	52
query42	115	106	103	103
query43	539	494	493	493
query44	1194	810	804	804
query45	187	170	170	170
query46	1147	748	731	731
query47	1994	1904	1921	1904
query48	476	375	375	375
query49	752	398	388	388
query50	830	426	439	426
query51	7322	7373	7036	7036
query52	105	92	91	91
query53	260	189	187	187
query54	572	458	452	452
query55	79	77	78	77
query56	265	236	256	236
query57	1200	1105	1094	1094
query58	214	219	232	219
query59	3243	2914	2984	2914
query60	279	271	256	256
query61	132	142	123	123
query62	755	647	669	647
query63	214	188	185	185
query64	1812	669	620	620
query65	3205	3170	3192	3170
query66	713	296	296	296
query67	15838	15349	15408	15349
query68	5480	557	556	556
query69	417	254	253	253
query70	1184	1109	1137	1109
query71	404	257	255	255
query72	6561	4019	3905	3905
query73	797	345	349	345
query74	10170	8878	8968	8878
query75	3348	2628	2597	2597
query76	2335	1024	1042	1024
query77	494	263	263	263
query78	10709	9731	9507	9507
query79	8921	586	580	580
query80	1973	420	406	406
query81	540	242	239	239
query82	1156	121	115	115
query83	314	139	139	139
query84	286	80	77	77
query85	1806	298	313	298
query86	455	306	301	301
query87	4426	4307	4235	4235
query88	5705	2367	2407	2367
query89	547	293	288	288
query90	2177	180	176	176
query91	182	141	146	141
query92	62	49	50	49
query93	6548	534	531	531
query94	908	287	288	287
query95	341	243	254	243
query96	630	282	281	281
query97	3407	3118	3150	3118
query98	218	207	205	205
query99	1608	1286	1275	1275
Total cold run time: 338202 ms
Total hot run time: 195568 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 32.37 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 8a5a8b0c3ebb80f8a8d6d531ca848d3b6d3cab58, data reload: false

query1	0.04	0.03	0.02
query2	0.07	0.03	0.02
query3	0.24	0.06	0.06
query4	1.62	0.10	0.10
query5	0.53	0.52	0.51
query6	1.13	0.73	0.72
query7	0.02	0.01	0.01
query8	0.04	0.04	0.03
query9	0.57	0.51	0.50
query10	0.55	0.55	0.56
query11	0.13	0.10	0.11
query12	0.14	0.10	0.11
query13	0.60	0.60	0.58
query14	2.97	3.08	2.92
query15	0.90	0.82	0.81
query16	0.39	0.39	0.37
query17	1.01	0.98	1.04
query18	0.23	0.21	0.21
query19	1.81	1.71	1.96
query20	0.01	0.01	0.01
query21	15.38	0.59	0.60
query22	2.37	2.00	1.49
query23	17.01	0.91	0.90
query24	2.59	0.95	1.73
query25	0.13	0.10	0.06
query26	0.44	0.15	0.15
query27	0.08	0.04	0.05
query28	10.54	1.10	1.07
query29	12.54	3.22	3.23
query30	0.26	0.06	0.06
query31	2.85	0.38	0.38
query32	3.25	0.47	0.48
query33	2.96	2.98	3.01
query34	17.00	4.41	4.39
query35	4.47	4.50	4.50
query36	0.68	0.51	0.49
query37	0.09	0.06	0.07
query38	0.06	0.03	0.03
query39	0.04	0.03	0.03
query40	0.17	0.13	0.13
query41	0.08	0.02	0.02
query42	0.03	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 106.06 s
Total hot run time: 32.37 s

@yiguolei yiguolei merged commit 3432361 into apache:branch-3.0 Dec 24, 2024
19 of 21 checks passed
@zhiqiang-hhhh zhiqiang-hhhh deleted the pick_45742_to_upstream_branch-3.0 branch December 25, 2024 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants