Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test](regression-test) use unified trigger_and_wait_compaction method #45761

Draft
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

py023
Copy link
Contributor

@py023 py023 commented Dec 22, 2024

What problem does this PR solve?

Problem Summary: Previously many regression cases use their own private functions to trigger compaction, results in a bunch of error-prone copy-pasted code. This PR introduces a unified method to trigger and wait compaction finished. Hopefully new cases won't need to write their own compaction method in the future.

Unsolved problem: Several cases(~20) have more dedicated actions to check compaction result, I didn't modify those cases in this PR, to avoid unexpected case behavior change. It's better to handle those cases in another PR, as it takes more times and this PR is already a huge change set.

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Dec 22, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@py023
Copy link
Contributor Author

py023 commented Dec 22, 2024

run buildall

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants