memtable flush reserve process mem and improve logs #45743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
yiguolei
reviewed
Dec 21, 2024
| @@ -278,34 +278,44 @@ inline void ThreadMemTrackerMgr::flush_untracked_mem() { | |||
| _stop_consume = false; | |||
| } | |||
|
|
|||
| inline doris::Status ThreadMemTrackerMgr::try_reserve(int64_t size) { | |||
| inline doris::Status ThreadMemTrackerMgr::try_reserve(int64_t size, | |||
yiguolei
reviewed
Dec 21, 2024
| @@ -249,13 +249,22 @@ class ThreadContext { | |||
| thread_mem_tracker_mgr->consume(size, skip_large_memory_check); | |||
| } | |||
|
|
|||
| doris::Status reserve_memory(const int64_t size) const { | |||
There was a problem hiding this comment.
xxx 和 try_xxx 区分不清楚是否要检查query和wg的limit。
我们换个名字，增加一个新的函数，try_reserve_process_memory
yiguolei
reviewed
Dec 21, 2024
| // Make sure at least one memtable is flushing even reserve memory failed. | ||
| if (memtable_flush_executor->check_and_inc_has_any_flushing_task()) { | ||
| // If there are already any flushing task, Wait for some time and retry. | ||
| LOG(INFO) << fmt::format( |
There was a problem hiding this comment.
这个每1min 打印一次吧，否则内存满的时候刷屏了
yiguolei
reviewed
Dec 21, 2024
| break; | ||
| } | ||
| if (_is_shutdown()) { | ||
| st = Status::Cancelled("flush memtable already cancelled"); |
There was a problem hiding this comment.
如果在等待期间，要flush的这个memtable 关联的导入任务呗cancel了，怎么处理？
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)