Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](fe) Disable releases for Apache snapshots repo #45423

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

adoroszlai
Copy link

What problem does this PR solve?

Problem Summary: while building fe, Maven looks for release artifacts in snapshots repo (and gets HTTP 404).

Repro:

$ mvn -DskipTests clean package
...
Downloading from snapshots: https://repository.apache.org/content/repositories/snapshots/com/google/cloud/first-party-dependencies/3.19.0/first-party-dependencies-3.19.0.pom
Downloading from cloudera: https://repository.cloudera.com/repository/libs-release-local/com/google/cloud/first-party-dependencies/3.19.0/first-party-dependencies-3.19.0.pom
Downloading from central: https://repo.maven.apache.org/maven2/com/google/cloud/first-party-dependencies/3.19.0/first-party-dependencies-3.19.0.pom
Downloaded from central: https://repo.maven.apache.org/maven2/com/google/cloud/first-party-dependencies/3.19.0/first-party-dependencies-3.19.0.pom (3.2 kB at 269 kB/s)
Downloading from snapshots: https://repository.apache.org/content/repositories/snapshots/com/google/cloud/google-cloud-shared-config/1.6.1/google-cloud-shared-config-1.6.1.pom
Downloading from cloudera: https://repository.cloudera.com/repository/libs-release-local/com/google/cloud/google-cloud-shared-config/1.6.1/google-cloud-shared-config-1.6.1.pom
Downloading from central: https://repo.maven.apache.org/maven2/com/google/cloud/google-cloud-shared-config/1.6.1/google-cloud-shared-config-1.6.1.pom
Downloaded from central: https://repo.maven.apache.org/maven2/com/google/cloud/google-cloud-shared-config/1.6.1/google-cloud-shared-config-1.6.1.pom (30 kB at 2.7 MB/s)
...

Repository list shows snapshots is configured for releases+snapshots:

$ mvn -N --batch-mode eu.maveniverse.maven.plugins:toolbox:list-repositories
...
[INFO] --- toolbox:0.6.0:list-repositories (default-cli) @ fe ---
[INFO] Remote repositories used by project org.apache.doris:fe:pom:1.2-SNAPSHOT.
[INFO]  * central (https://repo.maven.apache.org/maven2/, default, releases)
[INFO]    First introduced on root
[INFO]  * snapshots (https://repository.apache.org/content/repositories/snapshots/, default, releases+snapshots)
[INFO]    First introduced on root
[INFO]  * cloudera (https://repository.cloudera.com/repository/libs-release-local/, default, releases+snapshots)
[INFO]    First introduced on root
[INFO]  * apache.snapshots (https://repository.apache.org/snapshots, default, snapshots)
[INFO]    First introduced on root
[INFO]  * sonatype-nexus-snapshots (https://oss.sonatype.org/content/repositories/snapshots, default, snapshots)
[INFO]    First introduced on org.awaitility:awaitility:jar:4.2.0 (compile)

Excerpt from same list with the fix:

$ mvn -N --batch-mode eu.maveniverse.maven.plugins:toolbox:list-repositories
...
[INFO]  * snapshots (https://repository.apache.org/content/repositories/snapshots/, default, snapshots)
...

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Dec 14, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants