Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement](agg-func) Make covar functions get greater precisions #43786

Closed
wants to merge 1 commit into from

Conversation

zclllyybb
Copy link
Contributor

@zclllyybb zclllyybb commented Nov 12, 2024

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

covar function is more stable now:
before:

mysql> select col_decimal_37__12__undef_signed col_alias2425, col_largeint_undef_signed col_alias2426, covar(col_bigint_undef_signed_not_null, 1583928109) AS col_alias2427 from table_200_undef_partitions2_keys3_properties4_distributed_by54 where cos(col_tinyint_undef_signed) <= 811862185 and col_largeint_undef_signed = 245 GROUP BY col_alias2425,col_alias2426 ORDER BY col_alias2425,col_alias2426,col_alias2427 LIMIT 10;
+-----------------+---------------+---------------+
| col_alias2425   | col_alias2426 | col_alias2427 |
+-----------------+---------------+---------------+
|            NULL | 245           |            -8 |
......

or

mysql> select col_decimal_37__12__undef_signed col_alias2425, col_largeint_undef_signed col_alias2426, covar(col_bigint_undef_signed_not_null, 1583928109) AS col_alias2427 from table_200_undef_partitions2_keys3_properties4_distributed_by54 where cos(col_tinyint_undef_signed) <= 811862185 and col_largeint_undef_signed = 245 GROUP BY col_alias2425,col_alias2426 ORDER BY col_alias2425,col_alias2426,col_alias2427 LIMIT 10;
+-----------------+---------------+---------------+
| col_alias2425   | col_alias2426 | col_alias2427 |
+-----------------+---------------+---------------+
|            NULL | 245           |             0 |
......

now:

mysql> select col_decimal_37__12__undef_signed col_alias2425, col_largeint_undef_signed col_alias2426, covar(col_bigint_undef_signed_not_null, 1583928109) AS col_alias2427 from table_200_undef_partitions2_keys3_properties4_distributed_by54 where cos(col_tinyint_undef_signed) <= 811862185 and col_largeint_undef_signed = 245 GROUP BY col_alias2425,col_alias2426 ORDER BY col_alias2425,col_alias2426,col_alias2427 LIMIT 10;
+-----------------+---------------+---------------+
| col_alias2425   | col_alias2426 | col_alias2427 |
+-----------------+---------------+---------------+
|            NULL | 245           |          0.25 |
......

Release note

Some aggregate functions have greater precisions now

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
        • this result may be unstable.
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@zclllyybb
Copy link
Contributor Author

run buildall

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@zclllyybb zclllyybb closed this Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants